Skip to content

Commit 5108f62

Browse files
authored
Merge pull request #360 from kevin-bates/fix-leak-kernel-proc
Fix memory leak of kernel Popen object
2 parents 8f62a36 + f23b71a commit 5108f62

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

jupyter_client/manager.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,10 @@ def finish_shutdown(self, waittime=None, pollinterval=0.1):
272272
if self.is_alive():
273273
time.sleep(pollinterval)
274274
else:
275+
# If there's still a proc, wait and clear
276+
if self.has_kernel:
277+
self.kernel.wait()
278+
self.kernel = None
275279
break
276280
else:
277281
# OK, we've waited long enough.

0 commit comments

Comments
 (0)