Skip to content

Commit 54c86a0

Browse files
committed
fix regression in KM. be sure to raise an exception when a kernel doesn't start properly
1 parent dfc1a85 commit 54c86a0

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

jupyter_client/manager.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ async def wrapper(self, *args, **kwargs):
7676
except Exception as e:
7777
self._ready.set_exception(e)
7878
self.log.exception(self._ready.exception())
79+
raise e
7980

8081
return wrapper
8182

jupyter_client/multikernelmanager.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ async def _async_start_kernel(self, kernel_name: t.Optional[str] = None, **kwarg
207207
starter = ensure_async(km.start_kernel(**kwargs))
208208
fut = asyncio.ensure_future(self._add_kernel_when_ready(kernel_id, km, starter))
209209
self._pending_kernels[kernel_id] = fut
210-
211210
# Handling a Pending Kernel
212211
if self._using_pending_kernels():
213212
# If using pending kernels, do not block

0 commit comments

Comments
 (0)