More coverage (#885)

* more coverage

* fix test on windows

* fix script handling

* fix invocation

Author: blink1073

.github/workflows/main.yml

@@ -9,6 +9,12 @@ concurrency:
   group: ci-${{ github.ref }}
   cancel-in-progress: true
 
+defaults:
+  run:
+    shell:
+      bash -eux {0}
+
+
 jobs:
   pre-commit:
     runs-on: ubuntu-latest

pyproject.toml

@@ -88,16 +88,14 @@ build = "make -C docs html SPHINXOPTS='-W'"
 features = ["test"]
 [tool.hatch.envs.test.scripts]
 test = "python -m pytest -vv {args}"
-nowarn = "python -m pytest -vv -W default {args}"
+nowarn = "test -W default {args}"
 
 [tool.hatch.envs.cov]
 features = ["test"]
 dependencies = ["coverage", "pytest-cov"]
-[tool.hatch.envs.cov.env-vars]
-ARGS = "-vv --cov jupyter_client --cov-branch --cov-report term-missing:skip-covered"
 [tool.hatch.envs.cov.scripts]
-test = "python -m pytest $ARGS {args}"
-nowarn = "python -m pytest $ARGS -W default {args}"
+test = "python -m pytest -vv --cov jupyter_client --cov-branch --cov-report term-missing:skip-covered {args}"
+nowarn = "test -W default {args}"
 
 [tool.black]
 line-length = 100

tests/test_session.py

@@ -2,9 +2,11 @@
 # Copyright (c) Jupyter Development Team.
 # Distributed under the terms of the Modified BSD License.
 import hmac
+import math
 import os
 import platform
 import uuid
+import warnings
 from datetime import datetime
 from unittest import mock
 
@@ -518,10 +520,21 @@ def test_json_packer():
     with pytest.raises(ValueError):
         ss.json_packer(dict(a=ss.Session()))
     ss.json_packer(dict(a=datetime(2021, 4, 1, 12, tzinfo=tzlocal())))
+    with warnings.catch_warnings():
+        warnings.simplefilter("ignore")
+        ss.json_packer(dict(a=math.inf))
 
 
 def test_message_cls():
     m = ss.Message(dict(a=1))
     foo = dict(m)
     assert foo['a'] == 1
     assert m['a'] == 1, m['a']
+    assert 'a' in m
+    assert str(m) == "{'a': 1}"
+
+
+def test_session_factory():
+    s = ss.SessionFactory()
+    s.log.info(str(s.context))
+    s.context.destroy()

tests/test_ssh.py

@@ -1,9 +1,19 @@
+import socket
+
+import pytest
+
+from jupyter_client.ssh.tunnel import open_tunnel
 from jupyter_client.ssh.tunnel import select_random_ports
 
 
 def test_random_ports():
-    for i in range(4096):
+    for _ in range(4096):
         ports = select_random_ports(10)
         assert len(ports) == 10
         for p in ports:
             assert ports.count(p) == 1
+
+
+def test_open_tunnel():
+    with pytest.raises((RuntimeError, socket.error)):
+        open_tunnel("tcp://localhost:1234", "does.not.exist")