Skip to content

Commit cfe57c9

Browse files
author
Doug Blank
authored
Allow third-party kernels to get additional args
This removes special treatment of IPython console so that other kernels can get command-line args. This doesn't allow the passing of flags, but does allow filenames, etc. Once this fix is in place, kernels can get these args via self.parent.extra_args
1 parent 86a347d commit cfe57c9

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

jupyter_client/consoleapp.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,10 +285,8 @@ def init_kernel_manager(self):
285285
self.exit(1)
286286

287287
self.kernel_manager.client_factory = self.kernel_client_class
288-
# FIXME: remove special treatment of IPython kernels
289288
kwargs = {}
290-
if self.kernel_manager.ipykernel:
291-
kwargs['extra_arguments'] = self.kernel_argv
289+
kwargs['extra_arguments'] = self.kernel_argv
292290
self.kernel_manager.start_kernel(**kwargs)
293291
atexit.register(self.kernel_manager.cleanup_ipc_files)
294292

0 commit comments

Comments
 (0)