[pre-commit.ci] pre-commit autoupdate (#947)

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/charliermarsh/ruff-pre-commit: v0.0.260 → v0.0.263](astral-sh/ruff-pre-commit@v0.0.260...v0.0.263)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* sync deps and run lint

* fix rtd

* rtd

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steven Silvester <[email protected]>

Author: pre-commit-ci[bot]

.pre-commit-config.yaml

@@ -35,7 +35,7 @@ repos:
       - id: black
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.260
+    rev: v0.0.263
     hooks:
       - id: ruff
         args: ["--fix"]

.readthedocs.yaml

@@ -2,8 +2,11 @@ version: 2
 sphinx:
   configuration: docs/conf.py
 python:
-  version: 3.8
   install:
     # install jupyter-client itself
     - method: pip
       path: ".[docs]"
+build:
+  os: ubuntu-22.04
+  tools:
+     python: "3.11"

jupyter_client/launcher.py

@@ -152,7 +152,7 @@ def launch_kernel(
     try:
         # Allow to use ~/ in the command or its arguments
         cmd = [os.path.expanduser(s) for s in cmd]
-        proc = Popen(cmd, **kwargs)
+        proc = Popen(cmd, **kwargs)  # noqa
     except Exception as ex:
         try:
             msg = "Failed to run command:\n{}\n    PATH={!r}\n    with kwargs:\n{!r}\n"

jupyter_client/localinterfaces.py

@@ -36,7 +36,7 @@ def _get_output(cmd):
     if os.name == "nt":
         startupinfo = subprocess.STARTUPINFO()  # type:ignore[attr-defined]
         startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW  # type:ignore[attr-defined]
-    p = Popen(cmd, stdout=PIPE, stderr=PIPE, startupinfo=startupinfo)
+    p = Popen(cmd, stdout=PIPE, stderr=PIPE, startupinfo=startupinfo)  # noqa
     stdout, stderr = p.communicate()
     if p.returncode:
         msg = "Failed to run {}: {}".format(cmd, stderr.decode("utf8", "replace"))

jupyter_client/ssh/forward.py

@@ -62,8 +62,7 @@ def handle(self):
             return
 
         logger.debug(
-            "Connected!  Tunnel open %r -> %r -> %r"
-            % (
+            "Connected!  Tunnel open {!r} -> {!r} -> {!r}".format(
                 self.request.getpeername(),
                 chan.getpeername(),
                 (self.chain_host, self.chain_port),

pyproject.toml

@@ -111,7 +111,7 @@ test = "mypy --install-types --non-interactive {args:.}"
 dependencies = [
   "black[jupyter]==23.3.0",
   "mdformat>0.7",
-  "ruff==0.0.260",
+  "ruff==0.0.263",
 ]
 [tool.hatch.envs.lint.scripts]
 style = [
@@ -269,7 +269,8 @@ unfixable = [
 # N802 Function name `assertIn` should be lowercase
 # EM101 Exception must not use a string literal, assign to variable first
 # PLR2004 Magic value used in comparison
-"tests/*" = ["B011", "F841", "C408", "E402", "T201", "B007", "N802", "EM101", "EM102", "PLR2004"]
+# S603 `subprocess` call: check for execution of untrusted input
+"tests/*" = ["B011", "F841", "C408", "E402", "T201", "B007", "N802", "EM101", "EM102", "PLR2004", "S603"]
 # T201 `print` found
 "*app.py" = ["T201"]
 # F401 `._version.__version__` imported but unused

tests/signalkernel.py

@@ -39,7 +39,7 @@ def do_execute(
             "user_expressions": {},
         }
         if code == "start":
-            child = Popen(["bash", "-i", "-c", "sleep 30"], stderr=PIPE)
+            child = Popen(["bash", "-i", "-c", "sleep 30"], stderr=PIPE)  # noqa
             self.children.append(child)
             reply["user_expressions"]["pid"] = self.children[-1].pid
         elif code == "check":