Skip to content

Commit f06c5c5

Browse files
committed
Clarify comments per review
1 parent f07f863 commit f06c5c5

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

jupyter_client/blocking/client.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,12 @@ def wait_for_ready(self, timeout=None):
3636

3737
from ..manager import KernelManager
3838
if not isinstance(self.parent, KernelManager):
39-
# We aren't connected to a manager,
40-
# so first wait for kernel to become responsive to heartbeats
39+
# This Client was not created by a KernelManager,
40+
# so wait for kernel to become responsive to heartbeats
41+
# before checking for kernel_info reply
4142
while not self.is_alive():
4243
if time.time() > abs_timeout:
43-
raise RuntimeError("Kernel didn't respond to heartbeats in %d seconds" % timeout)
44+
raise RuntimeError("Kernel didn't respond to heartbeats in %d seconds and timed out" % timeout)
4445
time.sleep(0.2)
4546

4647
# Wait for kernel info reply on shell channel

jupyter_client/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,8 @@ def is_alive(self):
183183
"""Is the kernel process still running?"""
184184
from .manager import KernelManager
185185
if isinstance(self.parent, KernelManager):
186-
# We were created by a KernelManager, we can ask them:
186+
# This KernelClient was created by a KernelManager,
187+
# we can ask the parent KernelManager:
187188
return self.parent.is_alive()
188189
if self._hb_channel is not None:
189190
# We don't have access to the KernelManager,

jupyter_client/tests/signalkernel.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,7 @@ def init_io(self):
6464
pass # disable stdout/stderr capture
6565

6666
if __name__ == '__main__':
67+
# make startup artificially slow,
68+
# so that we exercise client logic for slow-starting kernels
6769
time.sleep(2)
6870
SignalTestApp.launch_instance()

0 commit comments

Comments
 (0)