Skip to content

Commit fe77c35

Browse files
committed
cleanup more unclosed sockets
1 parent 9533d15 commit fe77c35

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

tests/test_multikernelmanager.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from unittest import TestCase
1212

1313
import pytest
14+
import zmq
1415
from jupyter_core import paths
1516
from tornado.testing import AsyncTestCase, gen_test
1617
from traitlets.config.loader import Config
@@ -43,6 +44,11 @@ async def now(awaitable):
4344

4445
class TestKernelManager(TestCase):
4546
# static so picklable for multiprocessing on Windows
47+
48+
def tearDown(self):
49+
zmq.Context.instance().destroy(linger=0)
50+
return super().tearDown()
51+
4652
@staticmethod
4753
def _get_tcp_km():
4854
c = Config()
@@ -265,13 +271,16 @@ def record_activity(msg_list):
265271
time.sleep(0.1)
266272
if called:
267273
break
268-
274+
stream.close()
269275
client.stop_channels()
270276
km.shutdown_kernel(now=True)
271277

272278

273-
@pytest.mark.skipif(sys.version_info < (3, 10), reason="issue on 3.9")
274279
class TestAsyncKernelManager(AsyncTestCase):
280+
def tearDown(self):
281+
zmq.Context.instance().destroy(linger=0)
282+
return super().tearDown()
283+
275284
# static so picklable for multiprocessing on Windows
276285
@staticmethod
277286
def _get_tcp_km():
@@ -616,7 +625,7 @@ async def test_bad_kernelspec_pending(self):
616625
await ensure_future(km.shutdown_kernel(kernel_id))
617626
assert kernel_id not in km.list_kernel_ids()
618627

619-
@gen_test
628+
@gen_test(timeout=10)
620629
async def test_stream_on_recv(self):
621630
mkm = self._get_tcp_km()
622631
kid = await mkm.start_kernel(stdout=PIPE, stderr=PIPE)
@@ -645,4 +654,5 @@ def record_activity(msg_list):
645654
await asyncio.sleep(0.1)
646655

647656
client.stop_channels()
657+
stream.close()
648658
await km.shutdown_kernel(now=True)

0 commit comments

Comments
 (0)