Skip to content

Commit fe93a44

Browse files
authored
Use sp-repo-review (#971)
* use sp-repo-review * Adopt sp-repo-review * cleanup * fix typing * fixups
1 parent d15a736 commit fe93a44

23 files changed

+183
-131
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ concurrency:
1111

1212
defaults:
1313
run:
14-
shell:
15-
bash -eux {0}
16-
14+
shell: bash -eux {0}
1715

1816
jobs:
1917
check_release:
@@ -99,8 +97,8 @@ jobs:
9997
steps:
10098
- uses: actions/checkout@v4
10199
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
102-
- name: Run Linters
103-
run: |
100+
- name: Run Linters
101+
run: |
104102
hatch run typing:test
105103
hatch run lint:style
106104
pipx run interrogate -v .

.pre-commit-config.yaml

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
ci:
22
autoupdate_schedule: monthly
3+
autoupdate_commit_msg: "chore: update pre-commit hooks"
34

45
repos:
56
- repo: https://github.com/pre-commit/pre-commit-hooks
@@ -29,13 +30,44 @@ repos:
2930
hooks:
3031
- id: mdformat
3132

32-
- repo: https://github.com/psf/black
33+
- repo: https://github.com/pre-commit/mirrors-prettier
34+
rev: "v3.0.2"
35+
hooks:
36+
- id: prettier
37+
types_or: [yaml, html, json]
38+
39+
- repo: https://github.com/adamchainz/blacken-docs
40+
rev: "1.16.0"
41+
hooks:
42+
- id: blacken-docs
43+
additional_dependencies: [black==23.7.0]
44+
45+
- repo: https://github.com/psf/black-pre-commit-mirror
3346
rev: 23.7.0
3447
hooks:
3548
- id: black
3649

50+
- repo: https://github.com/codespell-project/codespell
51+
rev: "v2.2.5"
52+
hooks:
53+
- id: codespell
54+
args: ["-L", "sur,nd"]
55+
56+
- repo: https://github.com/pre-commit/pygrep-hooks
57+
rev: "v1.10.0"
58+
hooks:
59+
- id: rst-backticks
60+
- id: rst-directive-colons
61+
- id: rst-inline-touching-normal
62+
3763
- repo: https://github.com/astral-sh/ruff-pre-commit
3864
rev: v0.0.287
3965
hooks:
4066
- id: ruff
41-
args: ["--fix"]
67+
args: ["--fix", "--show-fixes"]
68+
69+
- repo: https://github.com/scientific-python/cookie
70+
rev: "2023.08.23"
71+
hooks:
72+
- id: sp-repo-review
73+
additional_dependencies: ["repo-review[cli]"]

.readthedocs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ python:
99
build:
1010
os: ubuntu-22.04
1111
tools:
12-
python: "3.11"
12+
python: "3.11"

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
### Enhancements made
3232

33-
- Allow kwargs when writting connection_file [#953](https://github.com/jupyter/jupyter_client/pull/953) ([@fecet](https://github.com/fecet))
33+
- Allow kwargs when writing connection_file [#953](https://github.com/jupyter/jupyter_client/pull/953) ([@fecet](https://github.com/fecet))
3434

3535
### Maintenance and upkeep improvements
3636

@@ -574,7 +574,7 @@ No merged PRs
574574

575575
### Enhancements made
576576

577-
- Further improvements to pending kernels managment [#732](https://github.com/jupyter/jupyter_client/pull/732) ([@Zsailer](https://github.com/Zsailer))
577+
- Further improvements to pending kernels management [#732](https://github.com/jupyter/jupyter_client/pull/732) ([@Zsailer](https://github.com/Zsailer))
578578

579579
### Maintenance and upkeep improvements
580580

docs/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
]
3939

4040
try:
41-
import enchant # type:ignore # noqa
41+
import enchant # type:ignore[import] # noqa
4242

4343
extensions += ["sphinxcontrib.spelling"]
4444
except ImportError:

docs/kernels.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,14 @@ JSON serialised dictionary containing the following keys and values:
143143
characters.
144144
- **language**: The name of the language of the kernel.
145145
When loading notebooks, if no matching kernelspec key (may differ across machines)
146-
is found, a kernel with a matching `language` will be used.
146+
is found, a kernel with a matching ``language`` will be used.
147147
This allows a notebook written on any Python or Julia kernel to be properly associated
148148
with the user's Python or Julia kernel, even if they aren't listed under the
149149
same name as the author's.
150150
- **interrupt_mode** (optional): May be either ``signal`` or ``message`` and
151151
specifies how a client is supposed to interrupt cell execution on this kernel,
152152
either by sending an interrupt ``signal`` via the operating system's
153-
signalling facilities (e.g. `SIGINT` on POSIX systems), or by sending an
153+
signalling facilities (e.g. ``SIGINT`` on POSIX systems), or by sending an
154154
``interrupt_request`` message on the control channel (see
155155
:ref:`msging_interrupt`). If this is not specified
156156
the client will default to ``signal`` mode.

0 commit comments

Comments
 (0)