windows fixes

Author: blink1073

jupyter_core/tests/test_command.py

@@ -56,7 +56,7 @@ def write_executable(path, source):
             import pkg_resources
 
             w = pkg_resources.resource_string("setuptools", "cli-32.exe")
-        except (ImportError, FileNotFoundError):
+        except (ImportError, FileNotFoundError, SystemError):
             pytest.skip("Need pkg_resources/setuptools to make scripts executable on Windows")
         exe.write(w, "wb")
         exe.chmod(0o700)

jupyter_core/tests/test_paths.py

@@ -417,7 +417,10 @@ def test_secure_write_win32():
     def fetch_win32_permissions(filename):
         """Extracts file permissions on windows using icacls"""
         role_permissions = {}
-        for index, line in enumerate(os.popen("icacls %s" % filename).read().splitlines()):
+        proc = os.popen("icacls %s" % filename)
+        lines = proc.read().splitlines()
+        proc.close()
+        for index, line in enumerate(lines):
             if index == 0:
                 line = line.split(filename)[-1].strip().lower()
             match = re.match(r"\s*([^:]+):\(([^\)]*)\)", line)

pyproject.toml

@@ -36,5 +36,5 @@ testpaths = [
 ]
 filterwarnings= [
   # Fail on warnings
-  "error"
+  "error",
 ]