Skip to content

Commit de1fe1f

Browse files
authored
Revert "breaking: require Python 3.9 (#428)" (#432)
This reverts commit a009e43.
1 parent 0d225fd commit de1fe1f

File tree

5 files changed

+9
-10
lines changed

5 files changed

+9
-10
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
os: [ubuntu-latest, windows-latest, macos-latest]
31-
python-version: ["3.9", "3.12", "3.13"]
31+
python-version: ["3.8", "3.12", "3.13"]
3232
include:
33+
- os: windows-latest
34+
python-version: "3.9"
3335
- os: ubuntu-latest
3436
python-version: "3.11"
3537
- os: ubuntu-latest

jupyter_core/paths.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@
1515
import sys
1616
import tempfile
1717
import warnings
18-
from collections.abc import Iterator
1918
from contextlib import contextmanager
2019
from pathlib import Path
21-
from typing import Any, Literal, Optional, overload
20+
from typing import Any, Iterator, Literal, Optional, overload
2221

2322
import platformdirs
2423

jupyter_core/utils/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,10 @@
99
import sys
1010
import threading
1111
import warnings
12-
from collections.abc import Awaitable
1312
from contextvars import ContextVar
1413
from pathlib import Path
1514
from types import FrameType
16-
from typing import Any, Callable, TypeVar, cast
15+
from typing import Any, Awaitable, Callable, TypeVar, cast
1716

1817

1918
def ensure_dir_exists(path: str | Path, mode: int = 0o777) -> None:

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ classifiers = [
1515
"Programming Language :: Python",
1616
"Programming Language :: Python :: 3"
1717
]
18-
requires-python = ">=3.9"
18+
requires-python = ">=3.8"
1919
dependencies = [
2020
"platformdirs>=2.5",
2121
"traitlets>=5.3",
@@ -103,7 +103,7 @@ build = [
103103

104104
[tool.mypy]
105105
files = "jupyter_core"
106-
python_version = "3.9"
106+
python_version = "3.8"
107107
strict = true
108108
enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
109109
warn_unreachable = true

tests/test_migrate.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,8 @@ def notice_m_dir(src, dst):
132132
called["migrate_dir"] = True
133133
return migrate_dir(src, dst)
134134

135-
with (
136-
patch.object(migrate_mod, "migrate_file", notice_m_file),
137-
patch.object(migrate_mod, "migrate_dir", notice_m_dir),
135+
with patch.object(migrate_mod, "migrate_file", notice_m_file), patch.object(
136+
migrate_mod, "migrate_dir", notice_m_dir
138137
):
139138
assert migrate_one(src, dst)
140139
assert called == {"migrate_file": True}

0 commit comments

Comments
 (0)