Merge pull request #55 from davidbrochart/multikernelmanager

Force client class to be async when kernel manager is MultiKernelManager

Author: MSeal

nbclient/client.py

@@ -388,6 +388,9 @@ async def async_start_new_kernel_client(self, **kwargs):
             except AttributeError:
                 raise AttributeError('self.km={} has no client() or get_kernel() method, '
                                      'what is this?'.format(self.km))
+            # since self.km is a MultiKernelManager, it might not be async
+            # so let's ensure the client is async
+            km.client_class = 'jupyter_client.asynchronous.AsyncKernelClient'
 
         self.kc = km.client()
         await ensure_async(self.kc.start_channels())

nbclient/tests/test_client.py

@@ -20,6 +20,7 @@
 import IPython
 from traitlets import TraitError
 from nbformat import NotebookNode
+from jupyter_client.asynchronous import AsyncKernelClient
 from jupyter_client import KernelManager, MultiKernelManager
 from jupyter_client.kernelspec import KernelSpecManager
 from nbconvert.filters import strip_ansi
@@ -424,8 +425,8 @@ def test_startnewkernel_with_multikernelmanager():
     kc, kernel_id = executor.start_new_kernel_client()
     # a multi kernel manager always gives back an id to the started kernel
     assert kernel_id is not None
-    # prove it initalized client
-    assert kc is not None
+    # prove it initalized an async client
+    assert isinstance(kc, AsyncKernelClient)
     # since we are not using the setup_kernel context manager,
     # cleanup has to be done manually
     kc.shutdown()