Skip to content

Commit b8abcb2

Browse files
committed
Handle errors
1 parent 24173a6 commit b8abcb2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

nbclient/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1086,7 +1086,7 @@ async def async_execute_expressions(self, cell, cell_index: int, expressions: t.
10861086
finally:
10871087
raise
10881088
self._check_raise_for_error(cell, exec_reply)
1089-
attachments = {key: val["data"] for key, val in exec_reply["content"]["user_expressions"].items()}
1089+
attachments = {key: val["data"] if "data" in val else {"traceback": "\n".join(val["traceback"])} for key, val in exec_reply["content"]["user_expressions"].items()}
10901090
cell.setdefault("attachments", {})
10911091
# remove old expressions from cell
10921092
cell["attachments"] = {key: val for key, val in cell["attachments"].items() if not key.startswith(MD_EXPRESSIONS_PREFIX)}

nbclient/tests/files/Markdown_expressions.ipynb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@
1515
"metadata": {},
1616
"attachments": {
1717
"md-expr-0": {"text/plain": "1"},
18-
"md-expr-1": {"text/plain": "'c'"}
18+
"md-expr-1": {"text/plain": "'c'"},
19+
"md-expr-2": {"traceback": "\u001b[0;31mNameError\u001b[0m\u001b[0;31m:\u001b[0m name 'c' is not defined\n"}
1920
},
2021
"source": [
2122
"# Variables\n",
2223
"\n",
23-
"{{ a }} {{ b }}"
24+
"{{ a }} {{ b }} {{ c }}"
2425
]
2526
}
2627
],

0 commit comments

Comments
 (0)