Skip to content

Commit e91436b

Browse files
committed
Removed python 3.5 support
1 parent 2be7ee2 commit e91436b

File tree

6 files changed

+6
-14
lines changed

6 files changed

+6
-14
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ language: python
22
sudo: false
33
matrix:
44
include:
5-
- python: 3.5
6-
env: TOXENV=py35
75
- python: 3.6
86
env: TOXENV=py36
97
- python: 3.7

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/jupyter/nbclient/master?filepath=binder%2Frun_nbclient.ipynb)
22
[![Travis Build Status](https://travis-ci.org/jupyter/nbclient.svg?branch=master)](https://travis-ci.org/jupyter/nbclient)
33
[![image](https://codecov.io/github/jupyter/nbclient/coverage.svg?branch=master)](https://codecov.io/github/jupyter/nbclient?branch=master)
4-
[![Python 3.5](https://img.shields.io/badge/python-3.5-blue.svg)](https://www.python.org/downloads/release/python-350/)
54
[![Python 3.6](https://img.shields.io/badge/python-3.6-blue.svg)](https://www.python.org/downloads/release/python-360/)
65
[![Python 3.7](https://img.shields.io/badge/python-3.7-blue.svg)](https://www.python.org/downloads/release/python-370/)
76
[![Python 3.8](https://img.shields.io/badge/python-3.8-blue.svg)](https://www.python.org/downloads/release/python-380/)
@@ -26,7 +25,7 @@ This library used to be part of [nbconvert](https://nbconvert.readthedocs.io/en/
2625

2726
## Python Version Support
2827

29-
This library currently supports python 3.5+ versions. As minor python
28+
This library currently supports python 3.6+ versions. As minor python
3029
versions are officially sunset by the python org nbclient will similarly
3130
drop support in the future.
3231

docs/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ applications.
2525
Python Version Support
2626
----------------------
2727

28-
This library currently supports python 3.5+ verisons. As minor python
28+
This library currently supports python 3.6+ verisons. As minor python
2929
versions are officially sunset by the python org nbclient will similarly
3030
drop support in the future.
3131

nbclient/client.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
import base64
33
from textwrap import dedent
44

5-
# For python 3.5 compatibility we import asynccontextmanager from async_generator instead of
6-
# contextlib, and we `await yield_()` instead of just `yield`
7-
from async_generator import asynccontextmanager, async_generator, yield_
5+
from async_generator import asynccontextmanager
86
from contextlib import contextmanager
97

108
from time import monotonic
@@ -410,7 +408,6 @@ def setup_kernel(self, **kwargs):
410408
self._cleanup_kernel()
411409

412410
@asynccontextmanager
413-
@async_generator # needed for python 3.5 compatibility
414411
async def async_setup_kernel(self, **kwargs):
415412
"""
416413
Context manager for setting up the kernel to execute a notebook.
@@ -426,7 +423,7 @@ async def async_setup_kernel(self, **kwargs):
426423
if not self.km.has_kernel:
427424
await self.async_start_new_kernel_client(**kwargs)
428425
try:
429-
await yield_(None) # would just yield in python >3.5
426+
yield
430427
finally:
431428
await self._async_cleanup_kernel()
432429

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def read_reqs(fname):
5151
long_description_content_type='text/markdown',
5252
packages=['nbclient'],
5353
include_package_data=True,
54-
python_requires=">=3.5",
54+
python_requires=">=3.6",
5555
install_requires=requirements,
5656
extras_require=extras_require,
5757
project_urls={
@@ -70,7 +70,6 @@ def read_reqs(fname):
7070
'License :: OSI Approved :: BSD License',
7171
'Programming Language :: Python',
7272
'Programming Language :: Python :: 3',
73-
'Programming Language :: Python :: 3.5',
7473
'Programming Language :: Python :: 3.6',
7574
'Programming Language :: Python :: 3.7',
7675
'Programming Language :: Python :: 3.8',

tox.ini

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tox]
22
skipsdist = true
3-
envlist = py{35,36,37,38}, flake8, dist, manifest, docs
3+
envlist = py{36,37,38}, flake8, dist, manifest, docs
44

55
# Linters
66
[testenv:flake8]
@@ -40,7 +40,6 @@ setenv =
4040
PYTHONHASHSEED = 0
4141
passenv = *
4242
basepython =
43-
py35: python3.5
4443
py36: python3.6
4544
py37: python3.7
4645
py38: python3.8

0 commit comments

Comments
 (0)