Drop tox

Author: davidbrochart

.github/workflows/main.yml

@@ -19,7 +19,7 @@ jobs:
         python-version: 3.8
     - uses: pre-commit/[email protected]
 
-  build-n-test-n-coverage:
+  build:
     name: Build, test and code coverage
     runs-on: ${{ matrix.os }}
     strategy:
@@ -39,17 +39,24 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v2
+
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v2
       with:
         python-version: ${{ matrix.python-version }}
+
     - name: Install dependencies
       run: |
-        python -m pip install --upgrade pip
-        pip install -e .[test]
-        pip install tox coverage tox-gh-actions
+        pip install .[test]
+        pip install coverage
+
+    - name: Type check
+      run: mypy nbclient
+
     - name: Run the tests
-      run: tox
+      run: |
+        pytest -vv --maxfail=2 --cov=nbclient --cov-report=xml -W always
+
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v2
       with:
@@ -58,3 +65,8 @@ jobs:
           env_vars: OS,PYTHON
           name: codecov-umbrella
           fail_ci_if_error: false
+
+    - name: Build documentation
+      run: |
+        pip install .[sphinx]
+        sphinx-build docs docs_build --color -W -bhtml

nbclient/cli.py

@@ -4,7 +4,7 @@
 from textwrap import dedent
 
 import nbformat
-from jupyter_core.application import JupyterApp
+from jupyter_core.application import JupyterApp  # type: ignore
 from traitlets import Bool, Integer, List, Unicode, default
 from traitlets.config import catch_config_error
 

nbclient/tests/test_client.py

@@ -13,13 +13,13 @@
 
 import nbformat
 import pytest
-import xmltodict
+import xmltodict  # type: ignore
 from ipython_genutils.py3compat import string_types
 from jupyter_client import KernelManager
 from jupyter_client.kernelspec import KernelSpecManager
-from nbconvert.filters import strip_ansi
+from nbconvert.filters import strip_ansi  # type: ignore
 from nbformat import NotebookNode
-from testpath import modified_env
+from testpath import modified_env  # type: ignore
 from traitlets import TraitError
 
 from .. import NotebookClient, execute

nbclient/util.py

@@ -32,9 +32,9 @@ def check_patch_tornado() -> None:
         import tornado.concurrent  # type: ignore
 
         if asyncio.Future not in tornado.concurrent.FUTURES:
-            tornado.concurrent.FUTURES = tornado.concurrent.FUTURES + (
+            tornado.concurrent.FUTURES = tornado.concurrent.FUTURES + (  # type: ignore
                 asyncio.Future,
-            )  # type: ignore
+            )
 
 
 def just_run(coro: Awaitable) -> Any:

requirements-dev.txt

@@ -1,5 +1,3 @@
-codecov
-coverage
 ipython
 ipykernel
 ipywidgets
@@ -8,9 +6,8 @@ pytest-cov>=2.6.1
 check-manifest
 flake8
 mypy
-tox
 xmltodict
-black; python_version >= '3.6'
+black
 pip>=18.1
 wheel>=0.31.0
 setuptools>=38.6.0

setup.py

@@ -11,9 +11,6 @@
 name = 'nbclient'
 
 local_path = os.path.dirname(__file__)
-# Fix for tox which manipulates execution pathing
-if not local_path:
-    local_path = '.'
 here = os.path.abspath(local_path)
 
 
@@ -31,7 +28,7 @@ def read_reqs(fname):
 requirements = read(os.path.join(os.path.dirname(__file__), "requirements.txt"))
 dev_reqs = read_reqs(os.path.join(os.path.dirname(__file__), 'requirements-dev.txt'))
 doc_reqs = read_reqs(os.path.join(os.path.dirname(__file__), 'docs/requirements-doc.txt'))
-extras_require = {"test": dev_reqs, "dev": dev_reqs, "sphinx": doc_reqs}
+extras_require = {"test": dev_reqs, "sphinx": doc_reqs}
 
 setup(
     name=name,