Commit 6b0ec9f
authored
Upgrade to support jupyter_client 8 (#1778)
When upgrading the dependency spec to include v8, some python tests
broke (see #1728). The tests
were failing with a timeout due to indefinitely blocked IO.
This originates in an infinitely-looping notebook and is caused by a
misconfiguration of the client connection. Currently using
`nbclient.NotebookClient` with a `jupyter_client.manager.KernelManager`
results in a deadlock. nbclient doesn't seem aware of this issue because
there is no test covering it. `NotebookClient` uses `AsyncKernelManager`
by default.
So why isn't nbgrader using it? nbgrader uses the NotebookClient via
nbconvert which just realized the same issue. Up until v7.3.1, nbconvert
has been hard-coding the default kernel manager to the sync version.
(see jupyter/nbconvert#1964)
Rather than require nbconvert>=7.3.1, this commit sets our own default
value to the async kernel manager.1 parent 3177072 commit 6b0ec9f
2 files changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
70 | 76 | | |
71 | 77 | | |
72 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
0 commit comments