fix cd.yml

- add missing NBVIEWER_CHART env
- clone nbviewer with actions/checkout

Author: minrk

.github/workflows/cd.yml

@@ -1,12 +1,11 @@
-name: Continuous Deployment
+name: Deploy
 
 # only allow one deploy workflow to be running at a time
 # serializes multiple outstanding deploys if PRs are merged before the last deploy finishes
 # ref: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#concurrency
 concurrency: deploy
 
-# Only trigger the workflow when pushing to master or a label is applied to a
-# Pull Request
+# Only trigger the workflow when pushing to main
 on:
   push:
     branches:
@@ -23,6 +22,7 @@ env:
   HELM_VERSION: "v3.12.0"
   KUBECONFIG: secrets/ovh-kubeconfig.yaml
   NBVIEWER_VERSION: "68472ab"
+  NBVIEWER_CHART: nbviewer/helm-chart/nbviewer
 
 jobs:
   # In this dedicated job to deploy our staging environment we build and push
@@ -32,27 +32,34 @@ jobs:
 
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           fetch-depth: 0
 
+      - name: Checkout nbviewer
+        uses: actions/checkout@v5
+        with:
+          repository: jupyter/nbviewer
+          ref: ${{ env.NBVIEWER_VERSION }}
+          path: nbviewer
+
       - name: Setup Python
         uses: actions/setup-python@v5
         with:
           python-version: "3.13"
           cache: pip
 
-      - name: "Stage 1: Install dependencies"
+      - name: Install dependencies
         run: |
           pip install --upgrade setuptools pip
           pip install --upgrade -r requirements.txt
 
-      - name: "Stage 1: Install kubectl ${{ env.KUBECTL_VERSION }}"
+      - name: Install kubectl
         uses: azure/setup-kubectl@v4
         with:
           version: ${{ env.KUBECTL_VERSION }}
 
-      - name: "Stage 1: Install and setup helm ${{ env.HELM_VERSION }}"
+      - name: Install and setup helm
         run: |
           curl -sf https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | DESIRED_VERSION=${HELM_VERSION} bash
 
@@ -61,17 +68,10 @@ jobs:
         env:
           GIT_CRYPT_KEY: ${{ secrets.GIT_CRYPT_KEY }}
 
-      - name: get nbviewer chart
-        run: |
-          git clone https://github.com/jupyter/nbviewer
-          cd nbviewer
-          git reset "${NBVIEWER_VERSION}" --hard
-          git log -1
-
       - name: deploy
         run: |
           bash deploy.sh
 
-      - name: "Test"
+      - name: test
         run: |
           pytest