more fixes

Author: Carreau

.github/workflows/test.yaml

@@ -32,6 +32,9 @@ jobs:
       - name: install
         run: |
           python3 -m pip install -r requirements.in -r requirements-dev.txt
+      - name: install mypy
+        run: |
+          python3 -m pip install mypy types-pycurl types-requests types-Markdown
 
       - name: pip freeze
         run: |

nbviewer/providers/github/handlers.py

@@ -233,16 +233,15 @@ async def get(self, user, repo, ref, path):
         # Account for possibility that GitHub API redirects us to get more accurate breadcrumbs
         # See: https://github.com/jupyter/nbviewer/issues/324
         example_file_url = contents[0]["html_url"]
-        match_group = re.match(
-            r"^" + self.github_url + r"(?P<user>[^\/]+)/(?P<repo>[^\/]+)/.*",
-            example_file_url,
+
+        if not example_file_url.startswith(self.github_url):
+            raise ValueError("Url will never match it does not start with same domain.")
+        ghu = (
+            self.github_url if self.github_url.endswith("/") else self.github_url + "/"
         )
 
-        if match_group is None:
-            raise ValueError(
-                f"Could not extract user/repo fromexample_file_url={example_file_url}"
-            )
-        user, repo = match_group.group("user", "repo")
+        example_file_path = example_file_url[len(ghu) :]
+        user, repo, *_more = example_file_path.split("/")
 
         base_url = "/github/{user}/{repo}/tree/{ref}".format(
             user=user, repo=repo, ref=ref

nbviewer/providers/github/tests/test_github.py

@@ -140,7 +140,7 @@ def test_github_tree_redirect(self):
         self.assertIn("global-exclude", r.text)
 
     @skip_unless_github_auth
-    def test_github_blob_redirect(self):
+    def test_github_blob_redirect_II(self):
         url = self.url("github/ipython/ipython/blob/rel-2.0.0/IPython")
         r = requests.get(url)
         self.assertEqual(r.status_code, 200)

nbviewer/tests/test_json.py

@@ -3,14 +3,15 @@
 from unittest import TestCase
 
 from jsonschema import validate
+from typing import Optional
 
 
 ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), "..", ".."))
 
 
 class JSONTestCase(TestCase):
-    json: str
-    schema: str
+    json: Optional[str] = None
+    schema: Optional[str] = None
 
     def test_json(self):
         if not self.json: