debug

Author: Carreau

nbviewer/providers/base.py

@@ -383,7 +383,7 @@ def reraise_client_error(self, exc):
 
         slim_body = escape(body[:300])
 
-        self.log.warn("Fetching %s failed with %s. Body=%s", url, msg, slim_body)
+        self.log.error("Fetching %s failed with %s. Body=%s", url, msg, slim_body)
         raise web.HTTPError(code, msg)
 
     @contextmanager

nbviewer/providers/github/handlers.py

@@ -155,6 +155,9 @@ async def get(self, user, repo):
         self.redirect(new_url)
 
 
+TEST_KEYS = {(1, 2, 3): ""}
+
+
 class GitHubTreeHandler(GithubClientMixin, BaseHandler):
     """list files in a github repo (like github tree)"""
 
@@ -198,16 +201,28 @@ def render_treelist_template(
             **namespace,
         )
 
-    @cached
-    async def get(self, user, repo, ref, path):
+    async def _internal_get(self, user: str, repo: str, path: str, ref: str) -> str:
+        key = (user, repo, path, ref)
+        with self.catch_client_error():
+            response = await self.github_client.get_contents(user, repo, path, ref=ref)
+            rt = response_text(response)
+        self.log.info("For key: {key!r} for response: {tr!r}")
+        return rt
+
+    # @cached
+    async def get(self, user: str, repo: str, ref, path):
+        assert isinstance(user, str)
+        assert isinstance(repo, str)
+        assert isinstance(ref, str)
+        assert isinstance(path, str)
         if not self.request.uri.endswith("/"):
             self.redirect(self.request.uri + "/")
             return
         path = path.rstrip("/")
-        with self.catch_client_error():
-            response = await self.github_client.get_contents(user, repo, path, ref=ref)
 
-        contents = json.loads(response_text(response))
+        r_text = await self._internal_get(user, repo, ref, path)
+
+        contents = json.loads(r_text)
 
         branches, tags = await self.refs(user, repo)
 

nbviewer/tests/test_security.py

@@ -31,16 +31,7 @@ def test_github_dirnames(self):
     @skip_unless_github_auth
     def test_gist_filenames(self):
 
-        from nbviewer.providers.github.client import AsyncGitHubClient
-
-        AsyncGitHubClient.fetch = lambda x: "123"
-
-        with patch(
-            "nbviewer.providers.github.client.AsyncGitHubClient.fetch"
-        ) as mock_fetch:
-            mock_fetch.return_value = "123"
-            self._xss("/gist/bburky/c020825874798a6544a7")
-            mock_fetch.assert_called_with("123")
+        self._xss("/gist/bburky/c020825874798a6544a7")
 
 
 class LocalDirectoryTraversalTestCase(LFRPTC):