cleanup

Author: Carreau

nbviewer/providers/base.py

@@ -19,8 +19,8 @@
 from urllib.parse import urlparse
 from urllib.parse import urlunparse
 
-import statsd #type: ignore
-from nbformat import current_nbformat #type:ignore
+import statsd  # type: ignore
+from nbformat import current_nbformat  # type:ignore
 from nbformat import reads
 from tornado import httpclient
 from tornado import web
@@ -41,9 +41,9 @@
     import pycurl
     from tornado.curl_httpclient import CurlError
 except ModuleNotFoundError:
-    pycurl = None #type: ignore
+    pycurl = None  # type: ignore
 
-    class CurlError(Exception): #type: ignore
+    class CurlError(Exception):  # type: ignore
         pass
 
 
@@ -417,8 +417,8 @@ async def fetch(self, url, **overrides):
 
     def write_error(self, status_code: int, **kwargs):
         """render custom error pages"""
-        exc_info = kwargs.get('exc_info', None)
-        message:str = ""
+        exc_info = kwargs.get("exc_info")
+        message: str = ""
         status_message = responses.get(status_code, "Unknown")
         exception = None
         if exc_info:

nbviewer/providers/github/handlers.py

@@ -202,15 +202,19 @@ def render_treelist_template(
         )
 
     async def _internal_get(self, user: str, repo: str, path: str, ref: str) -> str:
-        key = (user, repo, path, ref)
+        """
+        Hook into here later during testing – probably via a CLI.
+        Do avoid doing actual github requests.
+
+        We can't use typical mock/patch, as we are in two different processes.
+        """
         with self.catch_client_error():
             response = await self.github_client.get_contents(user, repo, path, ref=ref)
             rt = response_text(response)
-        self.log.info("For key: {key!r} for response: {tr!r}")
         return rt
 
-    # @cached
-    async def get(self, user: str, repo: str, ref, path):
+    @cached
+    async def get(self, user: str, repo: str, ref: str, path: str):
         assert isinstance(user, str)
         assert isinstance(repo, str)
         assert isinstance(ref, str)
@@ -220,9 +224,9 @@ async def get(self, user: str, repo: str, ref, path):
             return
         path = path.rstrip("/")
 
-        r_text = await self._internal_get(user, repo, ref, path)
-
-        contents = json.loads(r_text)
+        # TODO: check that we can't just use '.json()', it seem to me that recent
+        # requests and similar expose a .json().
+        contents = json.loads(await self._internal_get(user, repo, ref, path))
 
         branches, tags = await self.refs(user, repo)
 

nbviewer/templates/notebook.html

@@ -159,5 +159,12 @@
     Rendered
     <span class='date' data-date='{{date}}' title='{{date}}'>({{date}})</span>
   </p>
+<style>
+ /* I did not found other ways to override CSS for now */
+div.reveal {
+    font-size: 10px;
+
+}
+</style>
   {% endif %}
 {% endblock extra_footer %}

nbviewer/tests/test_security.py

@@ -20,16 +20,15 @@
 class XSSTestCase(NBViewerTestCase):
     def _xss(self, path, pattern="<script>alert"):
         r = requests.get(self.url() + path)
-        # self.assertEqual(r.status_code, 200)
-        # self.assertNotIn(pattern, r.content)
+        self.assertEqual(r.status_code, 200)
+        self.assertNotIn(pattern, r.content)
 
     @skip_unless_github_auth
     def test_github_dirnames(self):
         self._xss("/github/bburky/xss/tree/%3Cscript%3Ealert(1)%3C%2fscript%3E/")
 
     @skip_unless_github_auth
     def test_gist_filenames(self):
-
         self._xss("/gist/bburky/c020825874798a6544a7")