Skip to content

Commit 05ebf9d

Browse files
authored
Merge pull request #6592 from kostyafarber/issue-6552
Restyle about dialog
2 parents d5c9f54 + c48ad1a commit 05ebf9d

File tree

2 files changed

+34
-4
lines changed

2 files changed

+34
-4
lines changed

packages/help-extension/src/index.tsx

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,9 @@ const plugin: JupyterFrontEndPlugin<void> = {
125125
);
126126

127127
const notebookURL = 'https://github.com/jupyter/notebook';
128-
const linkLabel = trans.__('JUPYTER NOTEBOOK ON GITHUB');
128+
const contributorURL = 'https://github.com/jupyter/notebook/pulse';
129+
const aboutJupyter = trans.__('JUPYTER NOTEBOOK ON GITHUB');
130+
const contributorList = trans.__('CONTRIBUTOR LIST');
129131
const externalLinks = (
130132
<span>
131133
<a
@@ -134,15 +136,27 @@ const plugin: JupyterFrontEndPlugin<void> = {
134136
rel="noopener noreferrer"
135137
className="jp-Button-flat jp-AboutNotebook-about-externalLinks"
136138
>
137-
{linkLabel}
139+
{aboutJupyter}
140+
</a>
141+
<a
142+
href={contributorURL}
143+
target="_blank"
144+
rel="noopener noreferrer"
145+
className="jp-Button-flat jp-AboutNotebook-about-externalLinks"
146+
>
147+
{contributorList}
138148
</a>
139149
</span>
140150
);
141151
const version = trans.__('Version: %1', app.version);
152+
const copyright = trans.__('© 2021-2022 Jupyter Notebook Contributors');
142153
const body = (
143154
<>
144-
<span className="jp-AboutNotebook-body">{version}</span>
155+
<span className="jp-AboutNotebook-version">{version}</span>
145156
<div>{externalLinks}</div>
157+
<span className="jp-AboutNotebook-about-copyright">
158+
{copyright}
159+
</span>
146160
</>
147161
);
148162

packages/help-extension/style/base.css

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
.jp-AboutNotebook .jp-Dialog-header {
22
justify-content: center;
3+
padding: 0;
34
}
45

56
.jp-AboutNotebook-header {
@@ -13,12 +14,23 @@
1314
margin-left: 16px;
1415
}
1516

17+
.jp-AboutNotebook-version {
18+
color: var(--jp-ui-font-color1);
19+
font-size: var(--jp-ui-font-size1);
20+
padding: var(--jp-flat-button-padding);
21+
font-weight: 400;
22+
letter-spacing: 0.4px;
23+
line-height: 1.12;
24+
min-width: 360px;
25+
text-align: center;
26+
}
27+
1628
.jp-AboutNotebook-body {
1729
display: flex;
1830
font-size: var(--jp-ui-font-size2);
1931
padding: var(--jp-flat-button-padding);
2032
color: var(--jp-ui-font-color1);
21-
text-align: left;
33+
text-align: center;
2234
flex-direction: column;
2335
min-width: 360px;
2436
overflow: hidden;
@@ -37,6 +49,10 @@
3749
color: var(--jp-warn-color0);
3850
}
3951

52+
.jp-AboutNotebook-about-copyright {
53+
padding-top: 25px;
54+
}
55+
4056
.jp-AboutNotebook-shortcuts {
4157
padding: 10px;
4258
}

0 commit comments

Comments
 (0)