Skip to content

Commit 14fce8c

Browse files
blink1073blink1073
authored
Adopt sp-repo-review (#7039)
* adopt sp-repo-review * adopt sp-repo-review * fix typing * fix typing * undo redundant formatting * undo markdown changes * formatting
1 parent 5a31c64 commit 14fce8c

File tree

27 files changed

+233
-194
lines changed

27 files changed

+233
-194
lines changed

‎.github/actions/build-dist/action.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
name: "Build Jupyter Notebook"
2-
description: "Build Jupyter Notebook from source"
1+
name: 'Build Jupyter Notebook'
2+
description: 'Build Jupyter Notebook from source'
33
runs:
4-
using: "composite"
4+
using: 'composite'
55
steps:
66
- name: Base Setup
77
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

‎.github/dependabot.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
version: 2
22
updates:
3-
- package-ecosystem: "github-actions"
4-
directory: "/"
3+
- package-ecosystem: 'github-actions'
4+
directory: '/'
55
schedule:
6-
interval: "weekly"
7-
- package-ecosystem: "pip"
8-
directory: "/"
6+
interval: 'weekly'
7+
- package-ecosystem: 'pip'
8+
directory: '/'
99
schedule:
10-
interval: "weekly"
10+
interval: 'weekly'

‎.github/jupyterlab-probot.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
addBinderLink: false
2-
triageLabel: "status:Needs Triage"
2+
triageLabel: 'status:Needs Triage'

‎.github/workflows/build.yml‎

Lines changed: 27 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@ on:
55
branches: ['main']
66
pull_request:
77
schedule:
8-
- cron: "0 0 * * *"
8+
- cron: '0 0 * * *'
99

1010
permissions:
11-
contents:
12-
write
11+
contents: write
1312

1413
concurrency:
1514
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
@@ -26,11 +25,11 @@ jobs:
2625
build:
2726
runs-on: ubuntu-latest
2827
steps:
29-
- name: Checkout
30-
uses: actions/checkout@v4
28+
- name: Checkout
29+
uses: actions/checkout@v4
3130

32-
- name: Build
33-
uses: ./.github/actions/build-dist
31+
- name: Build
32+
uses: ./.github/actions/build-dist
3433

3534
test:
3635
runs-on: ubuntu-latest
@@ -41,28 +40,28 @@ jobs:
4140
# used by the jupyterlab/maintainer-tools base-setup action
4241
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
4342
steps:
44-
- name: Checkout
45-
uses: actions/checkout@v4
43+
- name: Checkout
44+
uses: actions/checkout@v4
4645

47-
- name: Base Setup
48-
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
46+
- name: Base Setup
47+
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
4948

50-
- name: Test the package
51-
run: hatch run cov:test
49+
- name: Test the package
50+
run: hatch run cov:test
5251

53-
- name: JavaScript tests
54-
run: |
55-
hatch run js_test
52+
- name: JavaScript tests
53+
run: |
54+
hatch run js_test
5655
57-
- name: Integration Tests
58-
run: |
59-
pip install .
60-
cd
61-
jupyter labextension list 2>&1 | grep -ie "@jupyter-notebook/lab-extension.*enabled.*ok" -
62-
jupyter server extension list 2>&1 | grep -ie "notebook.*enabled" -
63-
python -m jupyterlab.browser_check
56+
- name: Integration Tests
57+
run: |
58+
pip install .
59+
cd
60+
jupyter labextension list 2>&1 | grep -ie "@jupyter-notebook/lab-extension.*enabled.*ok" -
61+
jupyter server extension list 2>&1 | grep -ie "notebook.*enabled" -
62+
python -m jupyterlab.browser_check
6463
65-
- uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1
64+
- uses: jupyterlab/maintainer-tools/.github/actions/upload-coverage@v1
6665

6766
coverage:
6867
runs-on: ubuntu-latest
@@ -176,17 +175,17 @@ jobs:
176175
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
177176
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
178177
with:
179-
ignore_links: "https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main"
180-
ignore_glob: "ui-tests/test/notebooks/*"
178+
ignore_links: 'https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main'
179+
ignore_glob: 'ui-tests/test/notebooks/*'
181180

182181
test_lint:
183182
name: Test Lint
184183
runs-on: ubuntu-latest
185184
steps:
186185
- uses: actions/checkout@v4
187186
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
188-
- name: Run Linters
189-
run: |
187+
- name: Run Linters
188+
run: |
190189
hatch run typing:test
191190
hatch run lint:style
192191
pipx run interrogate -v .

‎.github/workflows/buildutils.yml‎

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -18,64 +18,64 @@ jobs:
1818
runs-on: ubuntu-latest
1919
timeout-minutes: 10
2020
steps:
21-
- name: Checkout
22-
uses: actions/checkout@v4
21+
- name: Checkout
22+
uses: actions/checkout@v4
2323

24-
- name: Base Setup
25-
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
24+
- name: Base Setup
25+
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
2626

27-
- name: Install dependencies
28-
run: |
29-
python -m pip install -U "jupyterlab>=4.0.2,<5" hatch
30-
jlpm
31-
jlpm run build
27+
- name: Install dependencies
28+
run: |
29+
python -m pip install -U "jupyterlab>=4.0.2,<5" hatch
30+
jlpm
31+
jlpm run build
3232
33-
- name: Configure git identity to commit
34-
run: |
35-
git config --global user.email "[email protected]"
36-
git config --global user.name "Your Name"
33+
- name: Configure git identity to commit
34+
run: |
35+
git config --global user.email "[email protected]"
36+
git config --global user.name "Your Name"
3737
38-
- name: Reset version
39-
run: |
40-
hatch version 9.8.7
41-
jlpm run lerna version 9.8.7 --no-push --force-publish --no-git-tag-version --yes
42-
git commit -am "Release 9.8.7"
38+
- name: Reset version
39+
run: |
40+
hatch version 9.8.7
41+
jlpm run lerna version 9.8.7 --no-push --force-publish --no-git-tag-version --yes
42+
git commit -am "Release 9.8.7"
4343
44-
- name: Patch Release
45-
run: |
46-
jlpm release:patch --force
44+
- name: Patch Release
45+
run: |
46+
jlpm release:patch --force
4747
48-
- name: Minor Release
49-
run: |
50-
jlpm release:bump minor --force
48+
- name: Minor Release
49+
run: |
50+
jlpm release:bump minor --force
5151
52-
- name: Release Cycle
53-
run: |
54-
# beta
55-
jlpm release:bump release --force
56-
# rc
57-
jlpm release:bump release --force
58-
# final
59-
jlpm release:bump release --force
52+
- name: Release Cycle
53+
run: |
54+
# beta
55+
jlpm release:bump release --force
56+
# rc
57+
jlpm release:bump release --force
58+
# final
59+
jlpm release:bump release --force
6060
61-
- name: Major Release
62-
run: |
63-
jlpm release:bump major --force
61+
- name: Major Release
62+
run: |
63+
jlpm release:bump major --force
6464
6565
npm:
6666
runs-on: ubuntu-latest
6767
steps:
68-
- name: Checkout
69-
uses: actions/checkout@v4
68+
- name: Checkout
69+
uses: actions/checkout@v4
7070

71-
- name: Install Python
72-
uses: actions/setup-python@v4
73-
with:
74-
python-version: '3.9'
75-
architecture: 'x64'
71+
- name: Install Python
72+
uses: actions/setup-python@v4
73+
with:
74+
python-version: '3.9'
75+
architecture: 'x64'
7676

77-
- name: Install dependencies
78-
run: |
79-
python -m pip install -U "jupyterlab>=4.0.2,<5" pip
80-
jlpm
81-
jlpm run build
77+
- name: Install dependencies
78+
run: |
79+
python -m pip install -U "jupyterlab>=4.0.2,<5" pip
80+
jlpm
81+
jlpm run build

‎.github/workflows/check-release.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
name: Check Release
22
on:
33
push:
4-
branches: ["main"]
4+
branches: ['main']
55
pull_request:
66

77
permissions:
8-
contents:
9-
write
8+
contents: write
109

1110
concurrency:
1211
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}

‎.github/workflows/lock.yml‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,8 @@ on:
55
- cron: '0 0 * * *'
66

77
permissions:
8-
issues:
9-
write
10-
pull-requests:
11-
write
8+
issues: write
9+
pull-requests: write
1210

1311
jobs:
1412
lock:

‎.github/workflows/prep-release.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
name: "Step 1: Prep Release"
1+
name: 'Step 1: Prep Release'
22
on:
33
workflow_dispatch:
44
inputs:
55
version_spec:
6-
description: "New Version Specifier"
7-
default: "next"
6+
description: 'New Version Specifier'
7+
default: 'next'
88
required: false
99
branch:
10-
description: "The branch to target"
10+
description: 'The branch to target'
1111
required: false
1212
post_version_spec:
13-
description: "Post Version Specifier"
13+
description: 'Post Version Specifier'
1414
required: false
1515
since:
16-
description: "Use PRs with activity since this date or git reference"
16+
description: 'Use PRs with activity since this date or git reference'
1717
required: false
1818
since_last_stable:
19-
description: "Use PRs with activity since the last stable git tag"
19+
description: 'Use PRs with activity since the last stable git tag'
2020
required: false
2121
type: boolean
2222
jobs:
@@ -37,6 +37,6 @@ jobs:
3737
since: ${{ github.event.inputs.since }}
3838
since_last_stable: ${{ github.event.inputs.since_last_stable }}
3939

40-
- name: "** Next Step **"
40+
- name: '** Next Step **'
4141
run: |
4242
echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}"

‎.github/workflows/publish-release.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
name: "Step 2: Publish Release"
1+
name: 'Step 2: Publish Release'
22
on:
33
workflow_dispatch:
44
inputs:
55
branch:
6-
description: "The target branch"
6+
description: 'The target branch'
77
required: false
88
release_url:
9-
description: "The URL of the draft GitHub release"
9+
description: 'The URL of the draft GitHub release'
1010
required: false
1111
steps_to_skip:
12-
description: "Comma separated list of steps to skip"
12+
description: 'Comma separated list of steps to skip'
1313
required: false
1414

1515
jobs:
@@ -41,13 +41,13 @@ jobs:
4141
target: ${{ github.event.inputs.target }}
4242
release_url: ${{ steps.populate-release.outputs.release_url }}
4343

44-
- name: "** Next Step **"
44+
- name: '** Next Step **'
4545
if: ${{ success() }}
4646
run: |
4747
echo "Verify the final release"
4848
echo ${{ steps.finalize-release.outputs.release_url }}
4949
50-
- name: "** Failure Message **"
50+
- name: '** Failure Message **'
5151
if: ${{ failure() }}
5252
run: |
5353
echo "Failed to Publish the Draft Release Url:"

‎.github/workflows/ui-tests.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: UI Tests
22

33
on:
44
push:
5-
branches: ["main"]
5+
branches: ['main']
66
pull_request:
77

88
concurrency:

0 commit comments

Comments
 (0)