Merge pull request #3195 from areading314/ar/limit_autcomplete_elements

takluyver · web-flow · commit 31215b857c04 · 2018-01-19T10:23:08.000Z
Limit length of GUI autocomplete to 1000
diff --git a/notebook/static/notebook/js/completer.js b/notebook/static/notebook/js/completer.js
@@ -306,7 +306,8 @@ define([
     };
 
     Completer.prototype.build_gui_list = function (completions) {
-        for (var i = 0; i < completions.length; ++i) {
+        var MAXIMUM_GUI_LIST_LENGTH = 1000;
+        for (var i = 0; i < completions.length && i < MAXIMUM_GUI_LIST_LENGTH; ++i) {
             var opt = $('<option/>').text(completions[i].str).addClass(completions[i].type);
             this.sel.append(opt);
         }

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,8 @@ define([`
`306`	`306`	`};`
`307`	`307`
`308`	`308`	`Completer.prototype.build_gui_list = function (completions) {`
`309`		`- for (var i = 0; i < completions.length; ++i) {`
	`309`	`+ var MAXIMUM_GUI_LIST_LENGTH = 1000;`
	`310`	`+ for (var i = 0; i < completions.length && i < MAXIMUM_GUI_LIST_LENGTH; ++i) {`
`310`	`311`	`var opt = $('<option/>').text(completions[i].str).addClass(completions[i].type);`
`311`	`312`	`this.sel.append(opt);`
`312`	`313`	`}`