Skip to content

Commit 4200fb5

Browse files
committed
Fix some test wait conditions
1 parent 6cc6a10 commit 4200fb5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ui-tests/test/general.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ test.describe('General', () => {
2323
".jp-Notebook-ExecutionIndicator[data-status='idle']"
2424
);
2525

26+
// wait for the checkpoint indicator to be displayed
27+
await page.waitForSelector('.jp-NotebookCheckpoint');
28+
2629
// force switching back to command mode to avoid capturing the cursor in the screenshot
2730
await page.evaluate(async () => {
2831
await window.jupyterapp.commands.execute('notebook:enter-command-mode');

ui-tests/test/notebook.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { expect } from '@playwright/test';
77

88
import { test } from './fixtures';
99

10-
import { runAndAdvance, waitForKernelReady } from './utils';
10+
import { runAndAdvance } from './utils';
1111

1212
const NOTEBOOK = 'example.ipynb';
1313

@@ -70,8 +70,6 @@ test.describe('Notebook', () => {
7070
);
7171
await page.goto(`notebooks/${tmpPath}/${notebook}`);
7272

73-
await waitForKernelReady(page);
74-
7573
// execute the first cell
7674
await runAndAdvance(page);
7775
await page

0 commit comments

Comments
 (0)