Skip to content

Commit 43df5af

Browse files
authored
Merge pull request #5174 from tirkarthi/fix-json-loads-encoding
Remove deprecated encoding parameter for Python 3.9 compatibility.
2 parents 8a67477 + c01b2cc commit 43df5af

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

notebook/tests/test_gateway.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def test_gateway_get_kernelspecs(self):
176176
with mocked_gateway:
177177
response = self.request('GET', '/api/kernelspecs')
178178
self.assertEqual(response.status_code, 200)
179-
content = json.loads(response.content.decode('utf-8'), encoding='utf-8')
179+
content = json.loads(response.content.decode('utf-8'))
180180
kspecs = content.get('kernelspecs')
181181
self.assertEqual(len(kspecs), 2)
182182
self.assertEqual(kspecs.get('kspec_bar').get('name'), 'kspec_bar')
@@ -186,7 +186,7 @@ def test_gateway_get_named_kernelspec(self):
186186
with mocked_gateway:
187187
response = self.request('GET', '/api/kernelspecs/kspec_foo')
188188
self.assertEqual(response.status_code, 200)
189-
kspec_foo = json.loads(response.content.decode('utf-8'), encoding='utf-8')
189+
kspec_foo = json.loads(response.content.decode('utf-8'))
190190
self.assertEqual(kspec_foo.get('name'), 'kspec_foo')
191191

192192
response = self.request('GET', '/api/kernelspecs/no_such_spec')
@@ -257,7 +257,7 @@ def create_session(self, kernel_name):
257257
# Create the kernel... (also tests get_kernel)
258258
response = self.request('POST', '/api/sessions', **kwargs)
259259
self.assertEqual(response.status_code, 201)
260-
model = json.loads(response.content.decode('utf-8'), encoding='utf-8')
260+
model = json.loads(response.content.decode('utf-8'))
261261
self.assertEqual(model.get('path'), nb_path)
262262
kernel_id = model.get('kernel').get('id')
263263
# ensure its in the running_kernels and name matches.
@@ -286,7 +286,7 @@ def is_kernel_running(self, kernel_id):
286286
# Get list of running kernels
287287
response = self.request('GET', '/api/kernels')
288288
self.assertEqual(response.status_code, 200)
289-
kernels = json.loads(response.content.decode('utf-8'), encoding='utf-8')
289+
kernels = json.loads(response.content.decode('utf-8'))
290290
self.assertEqual(len(kernels), len(running_kernels))
291291
for model in kernels:
292292
if model.get('id') == kernel_id:
@@ -305,7 +305,7 @@ def create_kernel(self, kernel_name):
305305

306306
response = self.request('POST', '/api/kernels', **kwargs)
307307
self.assertEqual(response.status_code, 201)
308-
model = json.loads(response.content.decode('utf-8'), encoding='utf-8')
308+
model = json.loads(response.content.decode('utf-8'))
309309
kernel_id = model.get('id')
310310
# ensure its in the running_kernels and name matches.
311311
running_kernel = running_kernels.get(kernel_id)
@@ -330,7 +330,7 @@ def restart_kernel(self, kernel_id):
330330
with mocked_gateway:
331331
response = self.request('POST', '/api/kernels/' + kernel_id + '/restart')
332332
self.assertEqual(response.status_code, 200)
333-
model = json.loads(response.content.decode('utf-8'), encoding='utf-8')
333+
model = json.loads(response.content.decode('utf-8'))
334334
restarted_kernel_id = model.get('id')
335335
# ensure its in the running_kernels and name matches.
336336
running_kernel = running_kernels.get(restarted_kernel_id)
@@ -345,4 +345,3 @@ def delete_kernel(self, kernel_id):
345345
response = self.request('DELETE', '/api/kernels/' + kernel_id)
346346
self.assertEqual(response.status_code, 204)
347347
self.assertEqual(response.reason, 'No Content')
348-

0 commit comments

Comments
 (0)