Merge pull request #3871 from parente/fix/shortcut-editor-enter

minrk · web-flow · commit 4650dabd058b · 2018-09-13T16:23:00.000+02:00
Fix Enter causes page reload in shortcuts editor
diff --git a/notebook/static/notebook/js/shortcuteditor.js b/notebook/static/notebook/js/shortcuteditor.js
@@ -50,6 +50,7 @@ var KeyBinding = createClass({
         that.props.onAddBindings(that.state.shrt, that.props.ckey);
       }
       that.state.shrt='';
+      event.preventDefault();
       return false;
     };
     return createElement('form', {className:'jupyter-keybindings',

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ var KeyBinding = createClass({`
`50`	`50`	`that.props.onAddBindings(that.state.shrt, that.props.ckey);`
`51`	`51`	`}`
`52`	`52`	`that.state.shrt='';`
	`53`	`+ event.preventDefault();`
`53`	`54`	`return false;`
`54`	`55`	`};`
`55`	`56`	`return createElement('form', {className:'jupyter-keybindings',`