Skip to content

Commit 46fed87

Browse files
authored
Fix traitlets typing (#7082)
1 parent b397a3b commit 46fed87

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

notebook/app.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,14 @@
3232
from notebook_shim.shim import NotebookConfigShimMixin # type:ignore[import]
3333
from tornado import web
3434
from traitlets import Bool, Unicode, default
35+
from traitlets.config.loader import Config
3536

3637
from ._version import __version__
3738

3839
HERE = os.path.dirname(__file__)
3940

41+
Flags = t.Dict[t.Union[str, t.Tuple[str, ...]], t.Tuple[t.Union[t.Dict[str, t.Any], Config], str]]
42+
4043
app_dir = get_app_dir()
4144
version = __version__
4245

@@ -253,7 +256,7 @@ class JupyterNotebookApp(NotebookConfigShimMixin, LabServerApp): # type:ignore[
253256
""",
254257
)
255258

256-
flags = flags
259+
flags: Flags = flags # type:ignore[assignment]
257260
flags["expose-app-in-browser"] = (
258261
{"JupyterNotebookApp": {"expose_app_in_browser": True}},
259262
"Expose the global app instance to browser via window.jupyterapp.",
@@ -264,31 +267,31 @@ class JupyterNotebookApp(NotebookConfigShimMixin, LabServerApp): # type:ignore[
264267
"Load custom CSS in template html files. Default is True",
265268
)
266269

267-
@default("static_dir") # type:ignore[misc]
270+
@default("static_dir")
268271
def _default_static_dir(self) -> str:
269272
return os.path.join(HERE, "static")
270273

271-
@default("templates_dir") # type:ignore[misc]
274+
@default("templates_dir")
272275
def _default_templates_dir(self) -> str:
273276
return os.path.join(HERE, "templates")
274277

275-
@default("app_settings_dir") # type:ignore[misc]
278+
@default("app_settings_dir")
276279
def _default_app_settings_dir(self) -> str:
277280
return pjoin(app_dir, "settings")
278281

279-
@default("schemas_dir") # type:ignore[misc]
282+
@default("schemas_dir")
280283
def _default_schemas_dir(self) -> str:
281284
return pjoin(app_dir, "schemas")
282285

283-
@default("themes_dir") # type:ignore[misc]
286+
@default("themes_dir")
284287
def _default_themes_dir(self) -> str:
285288
return pjoin(app_dir, "themes")
286289

287-
@default("user_settings_dir") # type:ignore[misc]
290+
@default("user_settings_dir")
288291
def _default_user_settings_dir(self) -> str:
289292
return t.cast(str, get_user_settings_dir())
290293

291-
@default("workspaces_dir") # type:ignore[misc]
294+
@default("workspaces_dir")
292295
def _default_workspaces_dir(self) -> str:
293296
return t.cast(str, get_workspaces_dir())
294297

0 commit comments

Comments
 (0)