Skip to content

Commit 498b0bc

Browse files
authored
Merge pull request #5666 from kevin-bates/bind-unix-socket
Remove unnecessary import of bind_unix_socket
2 parents 9cc562d + e32031f commit 498b0bc

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

notebook/notebookapp.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ def shutdown_server(server_info, timeout=5, log=None):
443443
"""
444444
from tornado import gen
445445
from tornado.httpclient import AsyncHTTPClient, HTTPClient, HTTPRequest
446-
from tornado.netutil import bind_unix_socket, Resolver
446+
from tornado.netutil import Resolver
447447
url = server_info['url']
448448
pid = server_info['pid']
449449
resolver = None
@@ -524,7 +524,15 @@ def shutdown_server(self, server):
524524

525525
def _shutdown_or_exit(self, target_endpoint, server):
526526
print("Shutting down server on %s..." % target_endpoint)
527-
if not self.shutdown_server(server):
527+
server_stopped = self.shutdown_server(server)
528+
if not server_stopped and sys.platform.startswith('win'):
529+
# the pid check on Windows appears to be unreliable, so fetch another
530+
# list of servers and ensure our server is not in the list before
531+
# sending the wrong impression.
532+
servers = list(list_running_servers(self.runtime_dir))
533+
if server not in servers:
534+
server_stopped = True
535+
if not server_stopped:
528536
sys.exit("Could not stop server on %s" % target_endpoint)
529537

530538
@staticmethod

0 commit comments

Comments
 (0)