Merge pull request #4622 from TeresaPartidaS/convert_execute_code_js_to_selenium

Migrate execute code test to selenium

Author: takluyver

notebook/tests/notebook/execute_code.js

@@ -0,0 +1,66 @@
+from selenium.webdriver.common.keys import Keys
+from .utils import shift, cmdtrl
+
+
+def test_execute_code(notebook):
+    browser = notebook.browser
+    
+    def clear_outputs():
+        return notebook.browser.execute_script(
+            "Jupyter.notebook.clear_all_output();")
+
+    # Execute cell with Javascript API
+    notebook.edit_cell(index=0, content='a=10; print(a)')
+    browser.execute_script("Jupyter.notebook.get_cell(0).execute();")
+    outputs = notebook.wait_for_cell_output(0)
+    assert outputs[0].text == '10'
+
+    # Execute cell with Shift-Enter
+    notebook.edit_cell(index=0, content='a=11; print(a)')
+    clear_outputs()
+    shift(notebook.browser, Keys.ENTER)
+    outputs = notebook.wait_for_cell_output(0)
+    assert outputs[0].text == '11'
+    notebook.delete_cell(index=1)
+
+    # Execute cell with Ctrl-Enter
+    notebook.edit_cell(index=0, content='a=12; print(a)')
+    clear_outputs()
+    cmdtrl(notebook.browser, Keys.ENTER)
+    outputs = notebook.wait_for_cell_output(0)
+    assert outputs[0].text == '12'
+
+    # Execute cell with toolbar button
+    notebook.edit_cell(index=0, content='a=13; print(a)')
+    clear_outputs()
+    notebook.browser.find_element_by_css_selector(
+        "button[data-jupyter-action='jupyter-notebook:run-cell-and-select-next']").click()
+    outputs = notebook.wait_for_cell_output(0)
+    assert outputs[0].text == '13'
+
+    # Set up two cells to test stopping on error
+    notebook.edit_cell(index=0, content='raise IOError')
+    notebook.edit_cell(index=1, content='a=14; print(a)')
+
+    # Default behaviour: stop on error
+    clear_outputs()
+    browser.execute_script("""
+        var cell0 = Jupyter.notebook.get_cell(0);
+        var cell1 = Jupyter.notebook.get_cell(1);
+        cell0.execute();
+        cell1.execute();
+    """)
+    outputs = notebook.wait_for_cell_output(0)
+    assert notebook.get_cell_output(1) == []
+
+    # Execute a cell with stop_on_error=false
+    clear_outputs()
+    browser.execute_script("""
+            var cell0 = Jupyter.notebook.get_cell(0);
+            var cell1 = Jupyter.notebook.get_cell(1);
+            cell0.execute(false);
+            cell1.execute();
+        """)
+    outputs = notebook.wait_for_cell_output(1)
+    assert outputs[0].text == '14'
+

notebook/tests/selenium/test_execute_code.py

@@ -218,6 +218,11 @@ def get_cell_contents(self, index=0, selector='div .CodeMirror-code'):
     def get_cell_output(self, index=0, output='output_subarea'):
         return self.cells[index].find_elements_by_class_name(output)
 
+    def wait_for_cell_output(self, index=0, timeout=10):
+        return WebDriverWait(self.browser, timeout).until(
+            lambda b: self.get_cell_output(index)
+        )
+
     def set_cell_metadata(self, index, key, value):
         JS = 'Jupyter.notebook.get_cell({}).metadata.{} = {}'.format(index, key, value)
         return self.browser.execute_script(JS)