Skip to content

Commit 7e140c5

Browse files
committed
When adapting also log the version jupyter_client is expecting.
It's still (IMHO) unclear how the adaptation goes. Like does "adapting to protocol X.Y.Z." mean the end-result is X.Y.Z or what you got is X.Y.Z and it's X.Y.W after adaptation.
1 parent d772277 commit 7e140c5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

notebook/services/kernels/handlers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ def _finish_kernel_info(self, info):
187187
protocol_version = info.get('protocol_version', client_protocol_version)
188188
if protocol_version != client_protocol_version:
189189
self.session.adapt_version = int(protocol_version.split('.')[0])
190-
self.log.info("Adapting to protocol v%s for kernel %s", protocol_version, self.kernel_id)
190+
self.log.info("Adapting to protocol v%s for kernel %s (client expecting %s)", protocol_version, self.kernel_id, client_protocol_version)
191191
if not self._kernel_info_future.done():
192192
self._kernel_info_future.set_result(info)
193193

0 commit comments

Comments
 (0)