Enforce version number at build time.

Prevent making releases with wrong version number that will confuse pip,
or make sdists to appear more recent than wheels.

Author: Carreau

notebook/static/base/js/namespace.js

@@ -73,7 +73,7 @@ define(function(){
     // tree
     jglobal('SessionList','tree/js/sessionlist');
 
-    Jupyter.version = "5.0.0-rc.1";
+    Jupyter.version = "5.0.0.dev";
     Jupyter._target = '_blank';
     return Jupyter;
 });

setupbase.py

@@ -14,6 +14,7 @@
 from __future__ import print_function
 
 import os
+import re
 import pipes
 import shutil
 import sys
@@ -69,6 +70,11 @@ def execfile(fname, globs, locs=None):
 version = version_ns['__version__']
 
 
+# vendored from pep440 package, we allow `.dev` suffix without trailing number.
+loose_pep440re = re.compile(r'^([1-9]\d*!)?(0|[1-9]\d*)(\.(0|[1-9]\d*))*((a|b|rc)(0|[1-9]\d*))?(\.post(0|[1-9]\d*))?(\.dev(0|[1-9]\d*)?)?$')
+if not loose_pep440re.match(version):
+    raise ValueError('Invalid version number `%s`, please follow pep440 convention or pip will get confused about which package is more recent.' % version)
+
 #---------------------------------------------------------------------------
 # Find packages
 #---------------------------------------------------------------------------