Skip to content

Commit c0d3e8b

Browse files
authored
Pin click<8.3 (#7729)
* Troubleshoot the failing CI * Revert "Troubleshoot the failing CI" This reverts commit 4bea8b4. * click... * try constraints * try * pipx * pipx * force * more pins
1 parent 9c5a275 commit c0d3e8b

File tree

10 files changed

+55
-3
lines changed

10 files changed

+55
-3
lines changed

.github/actions/build-dist/action.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: 'Build Jupyter Notebook'
2+
23
description: 'Build Jupyter Notebook from source'
4+
35
runs:
46
using: 'composite'
57
steps:
@@ -9,7 +11,7 @@ runs:
911
- name: Install dependencies
1012
shell: bash
1113
run: |
12-
python -m pip install hatch
14+
python -m pip install hatch "click<8.3.0"
1315
1416
- name: Build pypi distributions
1517
shell: bash

.github/workflows/build.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ jobs:
4646
- name: Base Setup
4747
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
4848

49+
- name: Pin click to avoid 8.3.0 issues
50+
run: pipx inject --force hatch "click<8.3.0"
51+
4952
- name: Test the package
5053
run: hatch run cov:test
5154

@@ -79,6 +82,8 @@ jobs:
7982
steps:
8083
- uses: actions/checkout@v5
8184
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
85+
- name: Pin click to avoid 8.3.0 issues
86+
run: pipx inject --force hatch "click<8.3.0"
8287
- run: |
8388
sudo apt-get update
8489
sudo apt install enchant-2 # for spelling
@@ -97,6 +102,8 @@ jobs:
97102
with:
98103
dependency_type: minimum
99104
python_version: '3.10'
105+
- name: Pin click to avoid 8.3.0 issues
106+
run: pipx inject --force hatch "click<8.3.0"
100107
- name: Run the unit tests
101108
run: |
102109
hatch run test:nowarn || hatch run test:nowarn --lf
@@ -110,6 +117,8 @@ jobs:
110117
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
111118
with:
112119
dependency_type: pre
120+
- name: Pin click to avoid 8.3.0 issues
121+
run: pipx inject --force hatch "click<8.3.0"
113122
- name: Run the tests
114123
run: |
115124
hatch run test:nowarn || hatch run test:nowarn --lf
@@ -172,6 +181,8 @@ jobs:
172181
steps:
173182
- uses: actions/checkout@v5
174183
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
184+
- name: Pin click to avoid 8.3.0 issues
185+
run: pipx inject --force hatch "click<8.3.0"
175186
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
176187
with:
177188
ignore_links: 'https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main https://nbviewer.jupyter.org https://stackoverflow.com https://github.com/[^/]+/?$'
@@ -183,6 +194,8 @@ jobs:
183194
steps:
184195
- uses: actions/checkout@v5
185196
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
197+
- name: Pin click to avoid 8.3.0 issues
198+
run: pipx inject --force hatch "click<8.3.0"
186199
- name: Run Linters
187200
run: |
188201
hatch run typing:test

.github/workflows/buildutils.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ concurrency:
1616
permissions:
1717
contents: read
1818

19+
1920
jobs:
2021
versioning:
2122
runs-on: ubuntu-latest
@@ -27,9 +28,12 @@ jobs:
2728
- name: Base Setup
2829
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
2930

31+
- name: Pin click to avoid 8.3.0 issues
32+
run: pipx inject --force hatch "click<8.3.0"
33+
3034
- name: Install dependencies
3135
run: |
32-
python -m pip install -U "jupyterlab>=4.5.0a0,<4.6" hatch
36+
python -m pip install -U "jupyterlab>=4.5.0a0,<4.6"
3337
jlpm
3438
jlpm run build
3539

.github/workflows/check-release.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,21 @@ concurrency:
1111
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
1212
cancel-in-progress: true
1313

14+
1415
jobs:
1516
check_release:
1617
runs-on: ubuntu-latest
1718
timeout-minutes: 30
1819
steps:
1920
- name: Checkout
2021
uses: actions/checkout@v5
22+
2123
- name: Base Setup
2224
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
25+
26+
- name: Pin click to avoid 8.3.0 issues
27+
run: pipx inject --force hatch "click<8.3.0"
28+
2329
- name: Check Release
2430
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
2531
with:

.github/workflows/playwright-update.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ on:
77
permissions:
88
contents: read
99

10+
1011
jobs:
1112
update-snapshots:
1213
if: >
@@ -83,6 +84,9 @@ jobs:
8384
- name: Base Setup
8485
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
8586

87+
- name: Pin click to avoid 8.3.0 issues
88+
run: pipx inject --force hatch "click<8.3.0"
89+
8690
- name: Build
8791
uses: ./.github/actions/build-dist
8892

.github/workflows/prep-release.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ on:
2323
description: "Use PRs with activity since the last stable git tag"
2424
required: false
2525
type: boolean
26+
27+
2628
jobs:
2729
prep_release:
2830
runs-on: ubuntu-latest
@@ -31,6 +33,9 @@ jobs:
3133
steps:
3234
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
3335

36+
- name: Pin click to avoid 8.3.0 issues
37+
run: pipx inject --force hatch "click<8.3.0"
38+
3439
- name: Prep Release
3540
id: prep-release
3641
uses: jupyter-server/jupyter_releaser/.github/actions/prep-release@v2

.github/workflows/publish-changelog.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,17 @@ on:
99
description: "The branch to target"
1010
required: false
1111

12+
1213
jobs:
1314
publish_changelog:
1415
runs-on: ubuntu-latest
1516
environment: release
1617
steps:
1718
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
1819

20+
- name: Pin click to avoid 8.3.0 issues
21+
run: pipx inject --force hatch "click<8.3.0"
22+
1923
- uses: actions/create-github-app-token@v2
2024
id: app-token
2125
with:

.github/workflows/publish-release.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ on:
1212
description: "Comma separated list of steps to skip"
1313
required: false
1414

15+
1516
jobs:
1617
publish_release:
1718
runs-on: ubuntu-latest
@@ -21,6 +22,12 @@ jobs:
2122
steps:
2223
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
2324

25+
- name: Install jupyter-releaser
26+
run: pipx install jupyter-releaser
27+
28+
- name: Pin click to avoid 8.3.0 issues
29+
run: pipx inject --force hatch "click<8.3.0"
30+
2431
- uses: actions/create-github-app-token@v2
2532
id: app-token
2633
with:

.github/workflows/ui-tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ concurrency:
1212
permissions:
1313
contents: read
1414

15+
1516
jobs:
1617
build:
1718
name: Build
@@ -39,6 +40,9 @@ jobs:
3940
- name: Base Setup
4041
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
4142

43+
- name: Pin click to avoid 8.3.0 issues
44+
run: pipx inject --force hatch "click<8.3.0"
45+
4246
- uses: actions/download-artifact@v5
4347
with:
4448
name: notebook-dist-${{ github.run_number }}

pyproject.toml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
requires = [
33
"hatchling>=1.11",
44
"jupyterlab>=4.5.0a3,<4.6",
5+
"click<8.3.0",
56
]
67
build-backend = "hatchling.build"
78

@@ -63,6 +64,7 @@ test = [
6364
"jupyter_server[test]>=2.4.0,<3",
6465
"jupyterlab_server[test]>=2.27.1,<3",
6566
"importlib-resources>=5.0;python_version<\"3.10\"",
67+
"click<8.3.0",
6668
]
6769
docs = [
6870
"myst_parser",
@@ -74,7 +76,8 @@ docs = [
7476
]
7577
dev = [
7678
"pre-commit",
77-
"hatch"
79+
"hatch",
80+
"click<8.3.0",
7881
]
7982

8083
[tool.hatch.version]

0 commit comments

Comments
 (0)