Skip to content

Commit dc64e03

Browse files
Make notebook 6.5.x point to nbclassic static assets (#6474)
* Initial WIP static files removal (it builds, but has bugs). * del nbclassic from __init__. * Removed unneeded CSS/JS compilation logic. * Removed more frontend web logic. * Added nbclassic as a proper notebook dependency. * Updated nbclassic dependency version. * Added nbclassic to pyproject.toml. * Moved DEFAULT_STATIC_FILES_PATH. * Removed JS tests. * Added nbclassic tgo docs build. * Adding blank pre-commit-config for CI checks. * Edited empty pre-commit-config * Added docs to enforce-label workflow. * Revised workflow comments. * Adding WIP version_spec value to check_release step. * Changed dev version number. * Revert "Changed dev version number." This reverts commit e666731. * Manual WIP version number update to 6.5.0.dev * Manual (WIP) version dummy value for CI check. * Revised version numbner (WIP). * Reverted version number to pre-PR value. * Pinned selenium version. * Removed setup.py jsversion call. * Removed webpack config. * Removed bower/other web files. * Disable test with modal dialog error. * Modified pip upgrade command.
1 parent e97f73d commit dc64e03

File tree

155 files changed

+69
-27232
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

155 files changed

+69
-27232
lines changed

.bowerrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

.github/workflows/check-release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ jobs:
6161
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v1
6262
with:
6363
token: ${{ secrets.GITHUB_TOKEN }}
64+
version_spec: 100.100.100
6465
- name: Check Links
6566
if: ${{ matrix.group == 'link_check' }}
6667
uses: jupyter-server/jupyter_releaser/.github/actions/check-links@v1

.github/workflows/enforce-label.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Pull requests to this repo should have a triage label,
2+
# this workflow ensures that this is the case.
3+
14
name: Enforce PR label
25

36
on:

.github/workflows/js.yml

Lines changed: 0 additions & 65 deletions
This file was deleted.

.github/workflows/python.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
architecture: 'x64'
2323
- name: Upgrade packaging dependencies
2424
run: |
25-
pip install --upgrade pip setuptools wheel --user
25+
python -m pip install --upgrade pip setuptools wheel --user
2626
- name: Get pip cache dir
2727
id: pip-cache
2828
run: |

.pre-commit-config.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
repos: []
2+

MANIFEST.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,10 @@ include CONTRIBUTING.rst
33
include README.md
44
include CHANGELOG.md
55
include package.json
6-
include bower.json
7-
include .bowerrc
86
include pyproject.toml
97
include setup.py
108
include setupbase.py
119
include Dockerfile
12-
include *.js
1310
graft tools
1411
graft notebook/tests
1512

bower.json

Lines changed: 0 additions & 30 deletions
This file was deleted.

docs/environment.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ dependencies:
1313
- sphinx
1414
- terminado
1515
- myst-parser
16+
- nbclassic>=0.4.0
1617
- pip:
1718
- nbsphinx
1819
- Send2Trash

notebook/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
"""The Jupyter HTML Notebook"""
22

33
import os
4-
# Packagers: modify this line if you store the notebook static files elsewhere
5-
DEFAULT_STATIC_FILES_PATH = os.path.join(os.path.dirname(__file__), "static")
64

75
# Packagers: modify the next line if you store the notebook template files
86
# elsewhere

0 commit comments

Comments
 (0)