Skip to content

Commit dcc8874

Browse files
committed
Feedback: remove socket on stop.
1 parent 5aa6e0d commit dcc8874

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

notebook/notebookapp.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,13 @@ def _shutdown_or_exit(self, target_endpoint, server):
517517
if not self.shutdown_server(server):
518518
sys.exit("Could not stop server on %s" % target_endpoint)
519519

520+
@staticmethod
521+
def _maybe_remove_unix_socket(socket_path):
522+
try:
523+
os.unlink(socket_path)
524+
except (OSError, IOError):
525+
pass
526+
520527
def start(self):
521528
servers = list(list_running_servers(self.runtime_dir))
522529
if not servers:
@@ -527,6 +534,8 @@ def start(self):
527534
sock = server.get('sock', None)
528535
if sock and sock == self.sock:
529536
self._shutdown_or_exit(sock, server)
537+
# Attempt to remove the UNIX socket after stopping.
538+
self._maybe_remove_unix_socket(sock)
530539
return
531540
elif self.port:
532541
port = server.get('port', None)

0 commit comments

Comments
 (0)