Skip to content

Commit e976dfd

Browse files
authored
Fix handling of default factory in the URL (#6873)
1 parent d518364 commit e976dfd

File tree

1 file changed

+3
-1
lines changed
  • packages/docmanager-extension/src

1 file changed

+3
-1
lines changed

packages/docmanager-extension/src/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ const opener: JupyterFrontEndPlugin<IDocumentWidgetOpener> = {
2424
provides: IDocumentWidgetOpener,
2525
activate: (app: JupyterFrontEnd) => {
2626
const baseUrl = PageConfig.getBaseUrl();
27+
const docRegistry = app.docRegistry;
2728
let id = 0;
2829
return new (class {
2930
open(widget: IDocumentWidget, options?: DocumentRegistry.IOpenOptions) {
@@ -42,7 +43,8 @@ const opener: JupyterFrontEndPlugin<IDocumentWidgetOpener> = {
4243
}
4344
let url = `${baseUrl}${route}/${path}`;
4445
// append ?factory only if it's not the default
45-
if (widgetName !== 'default') {
46+
const defaultFactory = docRegistry.defaultWidgetFactory(path);
47+
if (widgetName !== defaultFactory.name) {
4648
url = `${url}?factory=${widgetName}`;
4749
}
4850
window.open(url);

0 commit comments

Comments
 (0)