Skip to content

Commit f45e94b

Browse files
kevin-batestoonijn
authored andcommitted
Add comments indicating when dependency check can be removed
1 parent b505292 commit f45e94b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

notebook/notebookapp.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1392,10 +1392,10 @@ def init_configurables(self):
13921392
)
13931393
# Ensure the appropriate version of Python and jupyter_client is available.
13941394
if isinstance(self.kernel_manager, AsyncMappingKernelManager):
1395-
if sys.version_info < (3, 6):
1395+
if sys.version_info < (3, 6): # Can be removed once 3.5 is dropped.
13961396
raise ValueError("You are using `AsyncMappingKernelManager` in Python 3.5 (or lower) "
13971397
"which is not supported. Please upgrade Python to 3.6+ or change kernel managers.")
1398-
if not async_kernel_mgmt_available:
1398+
if not async_kernel_mgmt_available: # Can be removed once jupyter_client >= 6.1 is required.
13991399
raise ValueError("You are using `AsyncMappingKernelManager` without an appropriate "
14001400
"jupyter_client installed! Please upgrade jupyter_client or change kernel managers.")
14011401
self.log.info("Asynchronous kernel management has been configured to use '{}'.".

notebook/services/kernels/tests/test_kernels_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,9 @@ class AsyncKernelAPITest(KernelAPITest):
201201

202202
@classmethod
203203
def setup_class(cls):
204-
if not async_testing_enabled:
204+
if not async_testing_enabled: # Can be removed once jupyter_client >= 6.1 is required.
205205
raise SkipTest("AsyncKernelAPITest tests skipped due to down-level jupyter_client!")
206-
if sys.version_info < (3, 6):
206+
if sys.version_info < (3, 6): # Can be removed once 3.5 is dropped.
207207
raise SkipTest("AsyncKernelAPITest tests skipped due to Python < 3.6!")
208208
super(AsyncKernelAPITest, cls).setup_class()
209209

notebook/services/sessions/tests/test_sessions_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,9 @@ class AsyncSessionAPITest(SessionAPITest):
271271

272272
@classmethod
273273
def setup_class(cls):
274-
if not async_testing_enabled:
274+
if not async_testing_enabled: # Can be removed once jupyter_client >= 6.1 is required.
275275
raise SkipTest("AsyncSessionAPITest tests skipped due to down-level jupyter_client!")
276-
if sys.version_info < (3, 6):
276+
if sys.version_info < (3, 6): # Can be removed once 3.5 is dropped.
277277
raise SkipTest("AsyncSessionAPITest tests skipped due to Python < 3.6!")
278278
super(AsyncSessionAPITest, cls).setup_class()
279279

0 commit comments

Comments
 (0)