From 4bea8b461c5d96f6da81dc3483369fb5075a5eaa Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 11:09:50 +0200 Subject: [PATCH 1/9] Troubleshoot the failing CI --- package.json | 1 + pyproject.toml | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 90c2dd289b..38cf9a1ed6 100644 --- a/package.json +++ b/package.json @@ -33,6 +33,7 @@ "eslint:files": "eslint --fix", "get:lab:version": "node ./buildutils/lib/get-latest-lab-version.js", "integrity": "node buildutils/lib/ensure-repo.js", + "pack:all": "lerna exec -- npm pack", "prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"", "prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"", "prettier:files": "prettier --write", diff --git a/pyproject.toml b/pyproject.toml index b91a2ac965..13252ef36a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -125,7 +125,7 @@ build = "make -C docs html SPHINXOPTS='-W'" serve = "cd docs/build/html && python -m http.server" [tool.hatch.envs.default.scripts] -npm_pack = "jlpm lerna exec -- npm pack" +npm_pack = "jlpm run pack:all" js_test = "jlpm run build:test && jlpm run test" [tool.hatch.envs.test] From 8664219de04a876b446d11f4b4d223330cacdbdf Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 11:27:40 +0200 Subject: [PATCH 2/9] Revert "Troubleshoot the failing CI" This reverts commit 4bea8b461c5d96f6da81dc3483369fb5075a5eaa. --- package.json | 1 - pyproject.toml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index 38cf9a1ed6..90c2dd289b 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,6 @@ "eslint:files": "eslint --fix", "get:lab:version": "node ./buildutils/lib/get-latest-lab-version.js", "integrity": "node buildutils/lib/ensure-repo.js", - "pack:all": "lerna exec -- npm pack", "prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"", "prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"", "prettier:files": "prettier --write", diff --git a/pyproject.toml b/pyproject.toml index 13252ef36a..b91a2ac965 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -125,7 +125,7 @@ build = "make -C docs html SPHINXOPTS='-W'" serve = "cd docs/build/html && python -m http.server" [tool.hatch.envs.default.scripts] -npm_pack = "jlpm run pack:all" +npm_pack = "jlpm lerna exec -- npm pack" js_test = "jlpm run build:test && jlpm run test" [tool.hatch.envs.test] From bf792c320409820aa1cfcbd1f48581d4050fa2d2 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 11:28:00 +0200 Subject: [PATCH 3/9] click... --- pyproject.toml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index b91a2ac965..24e2a7991a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -2,6 +2,7 @@ requires = [ "hatchling>=1.11", "jupyterlab>=4.5.0a3,<4.6", + "click<8.3.0", ] build-backend = "hatchling.build" @@ -63,6 +64,7 @@ test = [ "jupyter_server[test]>=2.4.0,<3", "jupyterlab_server[test]>=2.27.1,<3", "importlib-resources>=5.0;python_version<\"3.10\"", + "click<8.3.0", ] docs = [ "myst_parser", @@ -74,7 +76,8 @@ docs = [ ] dev = [ "pre-commit", - "hatch" + "hatch", + "click<8.3.0", ] [tool.hatch.version] From 33816ce4b2268fe95cfcff3c37b02be07ba8a283 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 12:53:08 +0200 Subject: [PATCH 4/9] try constraints --- .github/constraints.txt | 1 + .github/workflows/build.yml | 1 + .github/workflows/buildutils.yml | 3 +++ .github/workflows/check-release.yml | 4 ++++ .github/workflows/playwright-update.yml | 3 +++ .github/workflows/prep-release.yml | 4 ++++ .github/workflows/publish-changelog.yml | 3 +++ .github/workflows/publish-release.yml | 3 +++ .github/workflows/ui-tests.yml | 3 +++ 9 files changed, 25 insertions(+) create mode 100644 .github/constraints.txt diff --git a/.github/constraints.txt b/.github/constraints.txt new file mode 100644 index 0000000000..588dfaf3dc --- /dev/null +++ b/.github/constraints.txt @@ -0,0 +1 @@ +click<8.3.0 diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 127476bc59..eba2149462 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,6 +16,7 @@ concurrency: env: PIP_DISABLE_PIP_VERSION_CHECK: 1 + PIP_CONSTRAINT: .github/constraints.txt defaults: run: diff --git a/.github/workflows/buildutils.yml b/.github/workflows/buildutils.yml index 7ef303d024..17697686c9 100644 --- a/.github/workflows/buildutils.yml +++ b/.github/workflows/buildutils.yml @@ -16,6 +16,9 @@ concurrency: permissions: contents: read +env: + PIP_CONSTRAINT: .github/constraints.txt + jobs: versioning: runs-on: ubuntu-latest diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index ab931d8fc6..ace616622b 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -11,6 +11,9 @@ concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} cancel-in-progress: true +env: + PIP_CONSTRAINT: .github/constraints.txt + jobs: check_release: runs-on: ubuntu-latest @@ -20,6 +23,7 @@ jobs: uses: actions/checkout@v5 - name: Base Setup uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Check Release uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2 with: diff --git a/.github/workflows/playwright-update.yml b/.github/workflows/playwright-update.yml index 85a255a0c0..9e8668c9ac 100644 --- a/.github/workflows/playwright-update.yml +++ b/.github/workflows/playwright-update.yml @@ -7,6 +7,9 @@ on: permissions: contents: read +env: + PIP_CONSTRAINT: .github/constraints.txt + jobs: update-snapshots: if: > diff --git a/.github/workflows/prep-release.yml b/.github/workflows/prep-release.yml index 396330bb97..465b6da6af 100644 --- a/.github/workflows/prep-release.yml +++ b/.github/workflows/prep-release.yml @@ -23,6 +23,10 @@ on: description: "Use PRs with activity since the last stable git tag" required: false type: boolean + +env: + PIP_CONSTRAINT: .github/constraints.txt + jobs: prep_release: runs-on: ubuntu-latest diff --git a/.github/workflows/publish-changelog.yml b/.github/workflows/publish-changelog.yml index c576a54877..d00b5cda3d 100644 --- a/.github/workflows/publish-changelog.yml +++ b/.github/workflows/publish-changelog.yml @@ -9,6 +9,9 @@ on: description: "The branch to target" required: false +env: + PIP_CONSTRAINT: .github/constraints.txt + jobs: publish_changelog: runs-on: ubuntu-latest diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index d5dc89c8be..251ec55d68 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -12,6 +12,9 @@ on: description: "Comma separated list of steps to skip" required: false +env: + PIP_CONSTRAINT: .github/constraints.txt + jobs: publish_release: runs-on: ubuntu-latest diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index 12108731a8..cd9f96887a 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -12,6 +12,9 @@ concurrency: permissions: contents: read +env: + PIP_CONSTRAINT: .github/constraints.txt + jobs: build: name: Build From c6d8bcfc17d8ac92aec27814004791c7f117506c Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 13:04:48 +0200 Subject: [PATCH 5/9] try --- .github/constraints.txt | 1 - .github/workflows/build.yml | 14 +++++++++++++- .github/workflows/buildutils.yml | 5 +++-- .github/workflows/check-release.yml | 6 ++++-- .github/workflows/playwright-update.yml | 5 +++-- .github/workflows/prep-release.yml | 5 +++-- .github/workflows/publish-changelog.yml | 5 +++-- .github/workflows/publish-release.yml | 5 +++-- .github/workflows/ui-tests.yml | 5 +++-- 9 files changed, 35 insertions(+), 16 deletions(-) delete mode 100644 .github/constraints.txt diff --git a/.github/constraints.txt b/.github/constraints.txt deleted file mode 100644 index 588dfaf3dc..0000000000 --- a/.github/constraints.txt +++ /dev/null @@ -1 +0,0 @@ -click<8.3.0 diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index eba2149462..35912df810 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,7 +16,6 @@ concurrency: env: PIP_DISABLE_PIP_VERSION_CHECK: 1 - PIP_CONSTRAINT: .github/constraints.txt defaults: run: @@ -47,6 +46,9 @@ jobs: - name: Base Setup uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - name: Test the package run: hatch run cov:test @@ -80,6 +82,8 @@ jobs: steps: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" - run: | sudo apt-get update sudo apt install enchant-2 # for spelling @@ -98,6 +102,8 @@ jobs: with: dependency_type: minimum python_version: '3.10' + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" - name: Run the unit tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -111,6 +117,8 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 with: dependency_type: pre + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" - name: Run the tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -173,6 +181,8 @@ jobs: steps: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" - uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1 with: ignore_links: 'https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main https://nbviewer.jupyter.org https://stackoverflow.com https://github.com/[^/]+/?$' @@ -184,6 +194,8 @@ jobs: steps: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" - name: Run Linters run: | hatch run typing:test diff --git a/.github/workflows/buildutils.yml b/.github/workflows/buildutils.yml index 17697686c9..f2ff555ba2 100644 --- a/.github/workflows/buildutils.yml +++ b/.github/workflows/buildutils.yml @@ -16,8 +16,6 @@ concurrency: permissions: contents: read -env: - PIP_CONSTRAINT: .github/constraints.txt jobs: versioning: @@ -30,6 +28,9 @@ jobs: - name: Base Setup uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - name: Install dependencies run: | python -m pip install -U "jupyterlab>=4.5.0a0,<4.6" hatch diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index ace616622b..829420819b 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -11,8 +11,6 @@ concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} cancel-in-progress: true -env: - PIP_CONSTRAINT: .github/constraints.txt jobs: check_release: @@ -21,9 +19,13 @@ jobs: steps: - name: Checkout uses: actions/checkout@v5 + - name: Base Setup uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - name: Check Release uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2 with: diff --git a/.github/workflows/playwright-update.yml b/.github/workflows/playwright-update.yml index 9e8668c9ac..a9553aabfc 100644 --- a/.github/workflows/playwright-update.yml +++ b/.github/workflows/playwright-update.yml @@ -7,8 +7,6 @@ on: permissions: contents: read -env: - PIP_CONSTRAINT: .github/constraints.txt jobs: update-snapshots: @@ -86,6 +84,9 @@ jobs: - name: Base Setup uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - name: Build uses: ./.github/actions/build-dist diff --git a/.github/workflows/prep-release.yml b/.github/workflows/prep-release.yml index 465b6da6af..91debc3578 100644 --- a/.github/workflows/prep-release.yml +++ b/.github/workflows/prep-release.yml @@ -24,8 +24,6 @@ on: required: false type: boolean -env: - PIP_CONSTRAINT: .github/constraints.txt jobs: prep_release: @@ -35,6 +33,9 @@ jobs: steps: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - name: Prep Release id: prep-release uses: jupyter-server/jupyter_releaser/.github/actions/prep-release@v2 diff --git a/.github/workflows/publish-changelog.yml b/.github/workflows/publish-changelog.yml index d00b5cda3d..88c3fac6fd 100644 --- a/.github/workflows/publish-changelog.yml +++ b/.github/workflows/publish-changelog.yml @@ -9,8 +9,6 @@ on: description: "The branch to target" required: false -env: - PIP_CONSTRAINT: .github/constraints.txt jobs: publish_changelog: @@ -19,6 +17,9 @@ jobs: steps: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - uses: actions/create-github-app-token@v2 id: app-token with: diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 251ec55d68..8b04547523 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -12,8 +12,6 @@ on: description: "Comma separated list of steps to skip" required: false -env: - PIP_CONSTRAINT: .github/constraints.txt jobs: publish_release: @@ -24,6 +22,9 @@ jobs: steps: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - uses: actions/create-github-app-token@v2 id: app-token with: diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index cd9f96887a..62c88ea2d8 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -12,8 +12,6 @@ concurrency: permissions: contents: read -env: - PIP_CONSTRAINT: .github/constraints.txt jobs: build: @@ -42,6 +40,9 @@ jobs: - name: Base Setup uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Pin click to avoid 8.3.0 issues + run: python -m pip install "click<8.3.0" + - uses: actions/download-artifact@v5 with: name: notebook-dist-${{ github.run_number }} From 62c2f3243d01ecdb4bb75508b7e5b6a9df47e823 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 13:45:28 +0200 Subject: [PATCH 6/9] pipx --- .github/workflows/build.yml | 12 ++++++------ .github/workflows/buildutils.yml | 2 +- .github/workflows/check-release.yml | 2 +- .github/workflows/playwright-update.yml | 2 +- .github/workflows/prep-release.yml | 2 +- .github/workflows/publish-changelog.yml | 2 +- .github/workflows/publish-release.yml | 2 +- .github/workflows/ui-tests.yml | 2 +- 8 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 35912df810..c7de537045 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -47,7 +47,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Test the package run: hatch run cov:test @@ -83,7 +83,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - run: | sudo apt-get update sudo apt install enchant-2 # for spelling @@ -103,7 +103,7 @@ jobs: dependency_type: minimum python_version: '3.10' - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Run the unit tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -118,7 +118,7 @@ jobs: with: dependency_type: pre - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Run the tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -182,7 +182,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1 with: ignore_links: 'https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main https://nbviewer.jupyter.org https://stackoverflow.com https://github.com/[^/]+/?$' @@ -195,7 +195,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Run Linters run: | hatch run typing:test diff --git a/.github/workflows/buildutils.yml b/.github/workflows/buildutils.yml index f2ff555ba2..4565ab0652 100644 --- a/.github/workflows/buildutils.yml +++ b/.github/workflows/buildutils.yml @@ -29,7 +29,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Install dependencies run: | diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index 829420819b..5a671ef811 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -24,7 +24,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Check Release uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2 diff --git a/.github/workflows/playwright-update.yml b/.github/workflows/playwright-update.yml index a9553aabfc..09f108bce9 100644 --- a/.github/workflows/playwright-update.yml +++ b/.github/workflows/playwright-update.yml @@ -85,7 +85,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Build uses: ./.github/actions/build-dist diff --git a/.github/workflows/prep-release.yml b/.github/workflows/prep-release.yml index 91debc3578..823e222815 100644 --- a/.github/workflows/prep-release.yml +++ b/.github/workflows/prep-release.yml @@ -34,7 +34,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - name: Prep Release id: prep-release diff --git a/.github/workflows/publish-changelog.yml b/.github/workflows/publish-changelog.yml index 88c3fac6fd..79ad75a65a 100644 --- a/.github/workflows/publish-changelog.yml +++ b/.github/workflows/publish-changelog.yml @@ -18,7 +18,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - uses: actions/create-github-app-token@v2 id: app-token diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 8b04547523..c2260e8df8 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -23,7 +23,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - uses: actions/create-github-app-token@v2 id: app-token diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index 62c88ea2d8..3e097ad42a 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -41,7 +41,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: python -m pip install "click<8.3.0" + run: pipx install "click<8.3.0" - uses: actions/download-artifact@v5 with: From ed4173ab04b2d5b460693adccd6733bfb154cb03 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 14:13:22 +0200 Subject: [PATCH 7/9] pipx --- .github/workflows/build.yml | 12 ++++++------ .github/workflows/buildutils.yml | 4 ++-- .github/workflows/check-release.yml | 2 +- .github/workflows/playwright-update.yml | 2 +- .github/workflows/prep-release.yml | 2 +- .github/workflows/publish-changelog.yml | 2 +- .github/workflows/publish-release.yml | 5 ++++- .github/workflows/ui-tests.yml | 2 +- 8 files changed, 17 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c7de537045..8292657c89 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -47,7 +47,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Test the package run: hatch run cov:test @@ -83,7 +83,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - run: | sudo apt-get update sudo apt install enchant-2 # for spelling @@ -103,7 +103,7 @@ jobs: dependency_type: minimum python_version: '3.10' - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Run the unit tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -118,7 +118,7 @@ jobs: with: dependency_type: pre - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Run the tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -182,7 +182,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1 with: ignore_links: 'https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main https://nbviewer.jupyter.org https://stackoverflow.com https://github.com/[^/]+/?$' @@ -195,7 +195,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Run Linters run: | hatch run typing:test diff --git a/.github/workflows/buildutils.yml b/.github/workflows/buildutils.yml index 4565ab0652..115ca035d0 100644 --- a/.github/workflows/buildutils.yml +++ b/.github/workflows/buildutils.yml @@ -29,11 +29,11 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Install dependencies run: | - python -m pip install -U "jupyterlab>=4.5.0a0,<4.6" hatch + python -m pip install -U "jupyterlab>=4.5.0a0,<4.6" jlpm jlpm run build diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index 5a671ef811..0d38434300 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -24,7 +24,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Check Release uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2 diff --git a/.github/workflows/playwright-update.yml b/.github/workflows/playwright-update.yml index 09f108bce9..acde206776 100644 --- a/.github/workflows/playwright-update.yml +++ b/.github/workflows/playwright-update.yml @@ -85,7 +85,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Build uses: ./.github/actions/build-dist diff --git a/.github/workflows/prep-release.yml b/.github/workflows/prep-release.yml index 823e222815..4128a26a49 100644 --- a/.github/workflows/prep-release.yml +++ b/.github/workflows/prep-release.yml @@ -34,7 +34,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - name: Prep Release id: prep-release diff --git a/.github/workflows/publish-changelog.yml b/.github/workflows/publish-changelog.yml index 79ad75a65a..b91d7e5159 100644 --- a/.github/workflows/publish-changelog.yml +++ b/.github/workflows/publish-changelog.yml @@ -18,7 +18,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - uses: actions/create-github-app-token@v2 id: app-token diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index c2260e8df8..7667b2bfa5 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -22,8 +22,11 @@ jobs: steps: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 + - name: Install jupyter-releaser + run: pipx install jupyter-releaser + - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - uses: actions/create-github-app-token@v2 id: app-token diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index 3e097ad42a..0c55af9178 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -41,7 +41,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx install "click<8.3.0" + run: pipx inject hatch "click<8.3.0" - uses: actions/download-artifact@v5 with: From 87c257f75e1854c7d54111923dfacdc5b4e89f8e Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 14:15:52 +0200 Subject: [PATCH 8/9] force --- .github/workflows/build.yml | 12 ++++++------ .github/workflows/buildutils.yml | 2 +- .github/workflows/check-release.yml | 2 +- .github/workflows/playwright-update.yml | 2 +- .github/workflows/prep-release.yml | 2 +- .github/workflows/publish-changelog.yml | 2 +- .github/workflows/publish-release.yml | 2 +- .github/workflows/ui-tests.yml | 2 +- 8 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8292657c89..f90f6ab50f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -47,7 +47,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Test the package run: hatch run cov:test @@ -83,7 +83,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - run: | sudo apt-get update sudo apt install enchant-2 # for spelling @@ -103,7 +103,7 @@ jobs: dependency_type: minimum python_version: '3.10' - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Run the unit tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -118,7 +118,7 @@ jobs: with: dependency_type: pre - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Run the tests run: | hatch run test:nowarn || hatch run test:nowarn --lf @@ -182,7 +182,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1 with: ignore_links: 'https://playwright.dev/docs/test-cli/ https://blog.jupyter.org/the-big-split-9d7b88a031a7 https://blog.jupyter.org/jupyter-ascending-1bf5b362d97e https://mybinder.org/v2/gh/jupyter/notebook/main https://nbviewer.jupyter.org https://stackoverflow.com https://github.com/[^/]+/?$' @@ -195,7 +195,7 @@ jobs: - uses: actions/checkout@v5 - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Run Linters run: | hatch run typing:test diff --git a/.github/workflows/buildutils.yml b/.github/workflows/buildutils.yml index 115ca035d0..87d6b7c8de 100644 --- a/.github/workflows/buildutils.yml +++ b/.github/workflows/buildutils.yml @@ -29,7 +29,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Install dependencies run: | diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index 0d38434300..301c9731a5 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -24,7 +24,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Check Release uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2 diff --git a/.github/workflows/playwright-update.yml b/.github/workflows/playwright-update.yml index acde206776..1b6dcf4be8 100644 --- a/.github/workflows/playwright-update.yml +++ b/.github/workflows/playwright-update.yml @@ -85,7 +85,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Build uses: ./.github/actions/build-dist diff --git a/.github/workflows/prep-release.yml b/.github/workflows/prep-release.yml index 4128a26a49..7e22796c1d 100644 --- a/.github/workflows/prep-release.yml +++ b/.github/workflows/prep-release.yml @@ -34,7 +34,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - name: Prep Release id: prep-release diff --git a/.github/workflows/publish-changelog.yml b/.github/workflows/publish-changelog.yml index b91d7e5159..76a99b9a60 100644 --- a/.github/workflows/publish-changelog.yml +++ b/.github/workflows/publish-changelog.yml @@ -18,7 +18,7 @@ jobs: - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - uses: actions/create-github-app-token@v2 id: app-token diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 7667b2bfa5..e1d90b12bb 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -26,7 +26,7 @@ jobs: run: pipx install jupyter-releaser - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - uses: actions/create-github-app-token@v2 id: app-token diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index 0c55af9178..b6fdc2e20b 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -41,7 +41,7 @@ jobs: uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - name: Pin click to avoid 8.3.0 issues - run: pipx inject hatch "click<8.3.0" + run: pipx inject --force hatch "click<8.3.0" - uses: actions/download-artifact@v5 with: From 3d8a7486cd2c0b9b24532373ea8a447617be3313 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 22 Sep 2025 14:25:17 +0200 Subject: [PATCH 9/9] more pins --- .github/actions/build-dist/action.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/actions/build-dist/action.yml b/.github/actions/build-dist/action.yml index 4747b69545..3b840d621a 100644 --- a/.github/actions/build-dist/action.yml +++ b/.github/actions/build-dist/action.yml @@ -1,5 +1,7 @@ name: 'Build Jupyter Notebook' + description: 'Build Jupyter Notebook from source' + runs: using: 'composite' steps: @@ -9,7 +11,7 @@ runs: - name: Install dependencies shell: bash run: | - python -m pip install hatch + python -m pip install hatch "click<8.3.0" - name: Build pypi distributions shell: bash