Skip to content

Commit be74f59

Browse files
YahiewiYahiewi
committed
Fix eslint configuration
1 parent 1a23007 commit be74f59

File tree

11 files changed

+137
-143
lines changed

11 files changed

+137
-143
lines changed

‎.copier-answers.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ has_binder: false
77
has_settings: true
88
kind: frontend
99
labextension_name: jupytercad-urdf
10-
project_short_description: A JupyterLab extension adding features like exporting jcad
11-
files to urdf.
10+
project_short_description:
11+
A JupyterLab extension adding features like exporting jcad
12+
files to urdf.
1213
python_name: jupytercad_urdf
1314
repository: https://github.com/Yahiewi/JupyterCAD-urdf.git
1415
test: true
15-

‎.eslintrc.js‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,20 @@ module.exports = {
1616
'@typescript-eslint/no-explicit-any': 'off',
1717
'@typescript-eslint/no-namespace': 'off',
1818
'@typescript-eslint/no-empty-interface': 'off',
19-
'@typescript-eslint/no-non-null-assertion': 'off'
19+
'@typescript-eslint/no-non-null-assertion': 'off',
20+
'@typescript-eslint/no-unnecessary-type-constraint': 'off'
2021
},
2122
ignorePatterns: [
2223
'lib/**',
2324
'jupytercad_urdf/labextension/**',
2425
'node_modules/**'
26+
],
27+
overrides: [
28+
{
29+
files: ['.eslintrc.js'],
30+
parserOptions: {
31+
project: null
32+
}
33+
}
2534
]
2635
};

‎.github/workflows/build.yml‎

Lines changed: 114 additions & 114 deletions
Original file line numberDiff line numberDiff line change
@@ -15,78 +15,78 @@ jobs:
1515
runs-on: ubuntu-latest
1616

1717
steps:
18-
- name: Checkout
19-
uses: actions/checkout@v4
20-
21-
- name: Base Setup
22-
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
23-
24-
- name: Install dependencies
25-
run: |
26-
python -m pip install -U "jupyterlab>=4.0.0,<5"
27-
pip install jupytercad
28-
29-
- name: Lint the extension
30-
run: |
31-
set -eux
32-
jlpm
33-
jlpm run lint:check
34-
35-
- name: Test the extension
36-
run: |
37-
set -eux
38-
jlpm run test
39-
40-
- name: Build the extension
41-
run: |
42-
set -eux
43-
python -m pip install .[test]
44-
45-
jupyter labextension list
46-
jupyter labextension list 2>&1 | grep -ie "jupytercad-urdf.*OK"
47-
python -m jupyterlab.browser_check
48-
49-
- name: Package the extension
50-
run: |
51-
set -eux
52-
53-
pip install build
54-
python -m build
55-
pip uninstall -y "jupytercad_urdf" jupyterlab
56-
57-
- name: Upload extension packages
58-
uses: actions/upload-artifact@v4
59-
with:
60-
name: extension-artifacts
61-
path: dist/jupytercad_urdf*
62-
if-no-files-found: error
18+
- name: Checkout
19+
uses: actions/checkout@v4
20+
21+
- name: Base Setup
22+
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
23+
24+
- name: Install dependencies
25+
run: |
26+
python -m pip install -U "jupyterlab>=4.0.0,<5"
27+
pip install jupytercad
28+
29+
- name: Lint the extension
30+
run: |
31+
set -eux
32+
jlpm
33+
jlpm run lint:check
34+
35+
- name: Test the extension
36+
run: |
37+
set -eux
38+
jlpm run test
39+
40+
- name: Build the extension
41+
run: |
42+
set -eux
43+
python -m pip install .[test]
44+
45+
jupyter labextension list
46+
jupyter labextension list 2>&1 | grep -ie "jupytercad-urdf.*OK"
47+
python -m jupyterlab.browser_check
48+
49+
- name: Package the extension
50+
run: |
51+
set -eux
52+
53+
pip install build
54+
python -m build
55+
pip uninstall -y "jupytercad_urdf" jupyterlab
56+
57+
- name: Upload extension packages
58+
uses: actions/upload-artifact@v4
59+
with:
60+
name: extension-artifacts
61+
path: dist/jupytercad_urdf*
62+
if-no-files-found: error
6363

6464
test_isolated:
6565
needs: build
6666
runs-on: ubuntu-latest
6767

6868
steps:
69-
- name: Install Python
70-
uses: actions/setup-python@v5
71-
with:
72-
python-version: '3.9'
73-
architecture: 'x64'
74-
- uses: actions/download-artifact@v4
75-
with:
76-
name: extension-artifacts
77-
- name: Install and Test
78-
run: |
79-
set -eux
80-
# Remove NodeJS, twice to take care of system and locally installed node versions.
81-
sudo rm -rf $(which node)
82-
sudo rm -rf $(which node)
83-
84-
pip install "jupyterlab>=4.0.0,<5" jupytercad jupytercad_urdf*.whl
85-
86-
87-
jupyter labextension list
88-
jupyter labextension list 2>&1 | grep -ie "jupytercad-urdf.*OK"
89-
python -m jupyterlab.browser_check --no-browser-test
69+
- name: Install Python
70+
uses: actions/setup-python@v5
71+
with:
72+
python-version: '3.9'
73+
architecture: 'x64'
74+
- uses: actions/download-artifact@v4
75+
with:
76+
name: extension-artifacts
77+
- name: Install and Test
78+
run: |
79+
set -eux
80+
# Remove NodeJS, twice to take care of system and locally installed node versions.
81+
sudo rm -rf $(which node)
82+
sudo rm -rf $(which node)
83+
84+
pip install "jupyterlab>=4.0.0,<5" jupytercad jupytercad_urdf*.whl
85+
86+
87+
jupyter labextension list
88+
jupyter labextension list 2>&1 | grep -ie "jupytercad-urdf.*OK"
89+
python -m jupyterlab.browser_check --no-browser-test
9090
9191
integration-tests:
9292
name: Integration tests
@@ -97,53 +97,53 @@ jobs:
9797
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/pw-browsers
9898

9999
steps:
100-
- name: Checkout
101-
uses: actions/checkout@v4
102-
103-
- name: Base Setup
104-
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
105-
106-
- name: Download extension package
107-
uses: actions/download-artifact@v4
108-
with:
109-
name: extension-artifacts
110-
111-
- name: Install the extension
112-
run: |
113-
set -eux
114-
python -m pip install "jupyterlab>=4.0.0,<5" jupytercad jupytercad_urdf*.whl
115-
116-
- name: Install dependencies
117-
working-directory: ui-tests
118-
env:
119-
YARN_ENABLE_IMMUTABLE_INSTALLS: 0
120-
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
121-
run: jlpm install
122-
123-
- name: Set up browser cache
124-
uses: actions/cache@v4
125-
with:
126-
path: |
127-
${{ github.workspace }}/pw-browsers
128-
key: ${{ runner.os }}-${{ hashFiles('ui-tests/yarn.lock') }}
129-
130-
- name: Install browser
131-
run: jlpm playwright install chromium
132-
working-directory: ui-tests
133-
134-
- name: Execute integration tests
135-
working-directory: ui-tests
136-
run: |
137-
jlpm playwright test
138-
139-
- name: Upload Playwright Test report
140-
if: always()
141-
uses: actions/upload-artifact@v4
142-
with:
143-
name: jupytercad_urdf-playwright-tests
144-
path: |
145-
ui-tests/test-results
146-
ui-tests/playwright-report
100+
- name: Checkout
101+
uses: actions/checkout@v4
102+
103+
- name: Base Setup
104+
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
105+
106+
- name: Download extension package
107+
uses: actions/download-artifact@v4
108+
with:
109+
name: extension-artifacts
110+
111+
- name: Install the extension
112+
run: |
113+
set -eux
114+
python -m pip install "jupyterlab>=4.0.0,<5" jupytercad jupytercad_urdf*.whl
115+
116+
- name: Install dependencies
117+
working-directory: ui-tests
118+
env:
119+
YARN_ENABLE_IMMUTABLE_INSTALLS: 0
120+
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
121+
run: jlpm install
122+
123+
- name: Set up browser cache
124+
uses: actions/cache@v4
125+
with:
126+
path: |
127+
${{ github.workspace }}/pw-browsers
128+
key: ${{ runner.os }}-${{ hashFiles('ui-tests/yarn.lock') }}
129+
130+
- name: Install browser
131+
run: jlpm playwright install chromium
132+
working-directory: ui-tests
133+
134+
- name: Execute integration tests
135+
working-directory: ui-tests
136+
run: |
137+
jlpm playwright test
138+
139+
- name: Upload Playwright Test report
140+
if: always()
141+
uses: actions/upload-artifact@v4
142+
with:
143+
name: jupytercad_urdf-playwright-tests
144+
path: |
145+
ui-tests/test-results
146+
ui-tests/playwright-report
147147
148148
check_links:
149149
name: Check Links
@@ -152,4 +152,4 @@ jobs:
152152
steps:
153153
- uses: actions/checkout@v4
154154
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
155-
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1
155+
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1

‎.github/workflows/check-release.yml‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
name: Check Release
22
on:
33
push:
4-
branches: ["main"]
4+
branches: ['main']
55
pull_request:
6-
branches: ["*"]
6+
branches: ['*']
77

88
concurrency:
99
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -20,11 +20,10 @@ jobs:
2020
- name: Check Release
2121
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
2222
with:
23-
2423
token: ${{ secrets.GITHUB_TOKEN }}
2524

2625
- name: Upload Distributions
2726
uses: actions/upload-artifact@v4
2827
with:
2928
name: jupytercad_urdf-releaser-dist-${{ github.run_number }}
30-
path: .jupyter_releaser_checkout/dist
29+
path: .jupyter_releaser_checkout/dist

‎.github/workflows/prep-release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,4 @@ jobs:
3939

4040
- name: '** Next Step **'
4141
run: |
42-
echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}"
42+
echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}"

‎.github/workflows/publish-release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,4 @@ jobs:
5959
if: ${{ failure() }}
6060
run: |
6161
echo "Failed to Publish the Draft Release Url:"
62-
echo ${{ steps.populate-release.outputs.release_url }}
62+
echo ${{ steps.populate-release.outputs.release_url }}

‎.github/workflows/update-integration-tests.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ jobs:
2020
github.event.comment.author_association == 'MEMBER'
2121
) && github.event.issue.pull_request && contains(github.event.comment.body, 'please update snapshots')
2222
runs-on: ubuntu-latest
23-
2423
steps:
2524
- name: React to the triggering comment
2625
run: |

‎.pre-commit-config.yaml‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,3 @@ repos:
2020
hooks:
2121
- id: prettier
2222
entry: prettier --no-error-on-unmatched-pattern --write --ignore-unknown
23-
24-
# ESLint for .ts/.tsx files
25-
- repo: https://github.com/pre-commit/mirrors-eslint
26-
rev: v9.30.1
27-
hooks:
28-
- id: eslint
29-
files: \.tsx?$
30-
types: [file]
31-
additional_dependencies:
32-
- '[email protected]'
33-
- '@typescript-eslint/[email protected]'
34-
- '@typescript-eslint/[email protected]'
35-
- '[email protected]'
36-
- '[email protected]'
37-
- '[email protected]'

‎.yarnrc.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
nodeLinker: node-modules
2-
enableImmutableInstalls: false
2+
enableImmutableInstalls: false

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,4 +233,4 @@
233233
}
234234
},
235235
"packageManager": "[email protected]+sha512.5f5f00843eae735dfab6f0442524603e987ceca55e98b36eb0120f4e58908e5b1406545321e46627dca97d15d562f23dc13fb96cabd4e6bc92d379f619001e4e"
236-
}
236+
}

0 commit comments

Comments
 (0)