Perform a dry run for transforms (#575)

Author: martinRenou

packages/base/src/3dview/mainview.tsx

@@ -429,16 +429,11 @@ export class MainView extends React.Component<IProps, IStates> {
             positionArray[2] + updatedPosition.z
           ];
 
-          this._model.sharedModel.updateObjectByName(objectName, {
-            data: {
-              key: 'parameters',
-              value: {
-                ...obj.parameters,
-                Placement: {
-                  ...obj.parameters.Placement,
-                  Position: newPosition
-                }
-              }
+          this._mainViewModel.maybeUpdateObjectParameters(objectName, {
+            ...obj.parameters,
+            Placement: {
+              ...obj.parameters.Placement,
+              Position: newPosition
             }
           });
         }

packages/base/src/3dview/mainviewmodel.ts

@@ -16,6 +16,7 @@ import {
   WorkerAction,
   IJCadContent
 } from '@jupytercad/schema';
+import { showErrorMessage } from '@jupyterlab/apputils';
 import { ObservableMap } from '@jupyterlab/observables';
 import { JSONValue, PromiseDelegate, UUID } from '@lumino/coreutils';
 import { IDisposable } from '@lumino/disposable';
@@ -171,6 +172,51 @@ export class MainViewModel implements IDisposable {
     });
   }
 
+  /**
+   * Try to update an object, performing a dry run first to make sure it's feasible.
+   */
+  async maybeUpdateObjectParameters(
+    name: string,
+    properties: { [key: string]: any }
+  ): Promise<void> {
+    // getContent already returns a deep copy of the content, we can change it safely here
+    const updatedContent = this.jcadModel.getContent();
+    for (const object of updatedContent.objects) {
+      if (object.name === name) {
+        object.parameters = {
+          ...object.parameters,
+          ...properties
+        };
+      }
+    }
+
+    // Try a dry run
+    const dryRunResult = await this.dryRun(updatedContent);
+    if (dryRunResult.status === 'error') {
+      showErrorMessage(
+        'Failed to update the desired shape',
+        'The tool was unable to update the desired shape due to invalid parameter values. The values you entered may not be compatible with the dimensions of your piece.'
+      );
+      return;
+    }
+
+    // Dry run was successful, ready to apply the update now
+    const meta: IDict = dryRunResult.shapeMetadata?.[name] ?? {};
+    const obj = this.jcadModel.sharedModel.getObjectByName(name);
+    if (obj) {
+      this.jcadModel.sharedModel.updateObjectByName(name, {
+        data: {
+          key: 'parameters',
+          value: {
+            ...obj.parameters,
+            ...properties
+          }
+        },
+        meta
+      });
+    }
+  }
+
   /**
    * Send a payload to the worker to test its feasibility.
    *

packages/base/src/panelview/objectproperties.tsx

@@ -9,7 +9,7 @@ import {
   IJupyterCadTracker,
   ISelection
 } from '@jupytercad/schema';
-import { ReactWidget, showErrorMessage } from '@jupyterlab/apputils';
+import { ReactWidget } from '@jupyterlab/apputils';
 import { PanelWithToolbar } from '@jupyterlab/ui-components';
 import { Panel } from '@lumino/widgets';
 import * as React from 'react';
@@ -193,43 +193,10 @@ class ObjectPropertiesReact extends React.Component<IProps, IStates> {
       return;
     }
 
-    // getContent already returns a deep copy of the content, we can change it safely here
-    const updatedContent = model.getContent();
-    for (const object of updatedContent.objects) {
-      if (object.name === objectName) {
-        object.parameters = {
-          ...object.parameters,
-          ...properties
-        };
-      }
-    }
-
-    // Try a dry run
-    const dryRunResult =
-      await currentWidget.content.currentViewModel.dryRun(updatedContent);
-    if (dryRunResult.status === 'error') {
-      showErrorMessage(
-        'Failed to update the shape',
-        'The tool was unable to update the desired shape due to invalid parameter values. The values you entered may not be compatible with the dimensions of your piece.'
-      );
-      return;
-    }
-
-    // Dry run was successful, ready to apply the update now
-    const meta: IDict = dryRunResult.shapeMetadata?.[objectName] ?? {};
-    const obj = model.sharedModel.getObjectByName(objectName);
-    if (obj) {
-      model.sharedModel.updateObjectByName(objectName, {
-        data: {
-          key: 'parameters',
-          value: {
-            ...obj['parameters'],
-            ...properties
-          }
-        },
-        meta
-      });
-    }
+    currentWidget.content.currentViewModel.maybeUpdateObjectParameters(
+      objectName,
+      properties
+    );
   }
 
   syncSelectedField = (