Use buildShape in objToMesh
#658
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests report: appsharing.space |
|
Preview PR at appsharing.space |
martinRenou
reviewed
Jan 8, 2025
Comment on lines
+1044
to
+1056
| if (mainMesh.material?.color) { | ||
| const originalMeshColor = new THREE.Color( | ||
| objColor || DEFAULT_MESH_COLOR | ||
| ); | ||
| mainMesh.material.color = originalMeshColor; | ||
| mainMesh.userData.originalColor = originalMeshColor.clone(); | ||
| } | ||
|
|
||
| edgesMeshes.forEach(edgeMesh => { | ||
| this._edgeMaterials.push(edgeMesh.material); | ||
| const edgeColor = new THREE.Color(objColor || DEFAULT_EDGE_COLOR); | ||
| edgeMesh.material.color = edgeColor; | ||
| }); |
There was a problem hiding this comment.
It seems weird to me we have to do this?
Shouldn't this be done in buildShape?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall close #605