Skip to content

Commit 02c4833

Browse files
committed
BatchSpawnerBase: Replace {host} with self.ip in connect_to_job_cmd.
For implementations other than condor_ssh_to_job, it might be useful to use the hostname on which the notebook was spawned to proxy it.
1 parent f373558 commit 02c4833

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

batchspawner/batchspawner.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def _req_keepvars_default(self):
190190
connect_to_job_cmd = Unicode('',
191191
help="Command to connect to running batch job and forward the port "
192192
"of the running notebook to the Hub. If empty, direct connectivity is assumed. "
193-
"Uses self.job_id as {job_id} and the self.port as {port}."
193+
"Uses self.job_id as {job_id}, self.port as {port} and self.ip as {host}."
194194
"If {rport} is used in this string, it is set to self.port, "
195195
"and a new random self.port is chosen locally and used as {port}."
196196
"This is useful e.g. for SSH port forwarding."
@@ -237,6 +237,7 @@ async def connect_to_job(self):
237237
a new random self.port is chosen locally (useful e.g. for SSH port forwarding).
238238
"""
239239
subvars = self.get_req_subvars()
240+
subvars['host'] = self.ip
240241
subvars['job_id'] = self.job_id
241242
if '{rport}' in self.connect_to_job_cmd:
242243
self.rport = self.port

0 commit comments

Comments
 (0)