Skip to content

Commit 33ddb8b

Browse files
authored
Fix tests by excluding broken version combo
Jupyterhub 0.9.6 used a deprecated import (sqlalchemy.interfaces) that was removed in Sqlalchemy 1.4. The python 3.5 environment only installs 1.3, but the python 3.9 environment now uses 1.4 and thus Jupyterhub fails to run. Excluding this test instead of adding a version pin since running such an old JHub in a very modern environment should be quite rare.
1 parent 1decdf2 commit 33ddb8b

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ jobs:
4040
# JupyterHub 1.3.0 requires python 3.6+
4141
- JHUB_VER: "1.3.0"
4242
python-version: "3.5"
43+
# JupyterHub 0.9.6 used a deprecated sqlalchemy feature removed in py3.9 environment
44+
- JHUB_VER: "0.9.6"
45+
python-version: "3.9"
4346
include:
4447
- JHUB_VER: "master"
4548
python-version: "3.9"

0 commit comments

Comments
 (0)