Skip to content

Commit a075914

Browse files
committed
Merge branch 'pr139_update' into singleuserapp_and_1.0
2 parents 37360e7 + ec4e0bc commit a075914

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

batchspawner/batchspawner.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,10 @@ def start(self):
372372
self.ip = self.state_gethost()
373373
while self.port == 0:
374374
yield gen.sleep(self.startup_poll_interval)
375+
# Test framework: For testing, mock_port is set because we
376+
# don't actually run the single-user server yet.
377+
if hasattr(self, 'mock_port'):
378+
self.port = self.mock_port
375379

376380
if jupyterhub.version_info < (0,7):
377381
# store on user for pre-jupyterhub-0.7:

batchspawner/tests/test_spawners.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def new_spawner(db, spawner_class=BatchDummy, **kwargs):
6464
kwargs.setdefault('server', server)
6565
kwargs.setdefault('hub', hub)
6666
kwargs.setdefault('user', user)
67-
kwargs.setdefault('current_port', testport)
67+
kwargs.setdefault('mock_port', testport)
6868
kwargs.setdefault('INTERRUPT_TIMEOUT', 1)
6969
kwargs.setdefault('TERM_TIMEOUT', 1)
7070
kwargs.setdefault('KILL_TIMEOUT', 1)
@@ -84,7 +84,7 @@ def check_ip(spawner, value):
8484
if version_info < (0,7):
8585
assert spawner.user.server.ip == value
8686
else:
87-
assert spawner.current_ip == value
87+
assert spawner.ip == value
8888

8989
def test_spawner_start_stop_poll(db, io_loop):
9090
spawner = new_spawner(db=db)

0 commit comments

Comments
 (0)