Skip to content

Commit b7dbb84

Browse files
committed
Merge PR#149 plus one more commit into dev
2 parents 38e1bae + da150bb commit b7dbb84

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Common attributes of batch submission / resource manager environments will inclu
4747

4848
### Example
4949

50-
Every effort has been made to accomodate highly diverse systems through configuration
50+
Every effort has been made to accommodate highly diverse systems through configuration
5151
only. This example consists of the (lightly edited) configuration used by the author
5252
to run Jupyter notebooks on an academic supercomputer cluster.
5353

@@ -90,7 +90,7 @@ to run Jupyter notebooks on an academic supercomputer cluster.
9090

9191
Unless otherwise stated for a specific spawner, assume that spawners
9292
*do* evaluate shell environment for users and thus the [security
93-
requiremnts of JupyterHub security for untrusted
93+
requirements of JupyterHub security for untrusted
9494
users](https://jupyterhub.readthedocs.io/en/stable/reference/websecurity.html)
9595
are not fulfilled because some (most?) spawners *do* start a user
9696
shell which will execute arbitrary user environment configuration
@@ -183,7 +183,7 @@ Changed
183183
- If you have installed with `pip install -e`, you will have to re-install so that the new script `batchspawner-singleuser` is added to `$PATH`.
184184
* Update minimum requirements to JupyterHub 0.9 and Python 3.5. #143
185185
* Update Slurm batch script. Now, the single-user notebook is run in a job step, with a wrapper of `srun`. This may need to be removed using `req_srun=''` if you don't want environment variables limited.
186-
* Pass the environment dictionary to the queue and cancel commands as well. This is mostly user environment, but may be useful to these commands as well in some cases. #108, #111 If these envioronment variables were used for authentication as an admin, be aware that there are pre-existing security issues because they may be passed to the user via the batch submit command, see #82.
186+
* Pass the environment dictionary to the queue and cancel commands as well. This is mostly user environment, but may be useful to these commands as well in some cases. #108, #111 If these environment variables were used for authentication as an admin, be aware that there are pre-existing security issues because they may be passed to the user via the batch submit command, see #82.
187187

188188

189189
Fixed

SPAWNERS.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11
# Notes on specific spawners
22

3+
**Spawner maintainers**: Included below are "spawner maintainers",
4+
when available. There aren't official obligations, but the general
5+
idea is that you should watch the repository and feel especially
6+
empowered to comment on issues when you think it might be relevant to
7+
you (obviously everyone should be, but this is our attempt at even
8+
more outreach). You should let us know when we break something and
9+
provide a diversity of opinions in general. Submitting PRs and
10+
testing is nice but not required.
11+
12+
To be listed as a maintainer, just submit an issue or PR adding you,
13+
and please watch the repository on Github.
14+
315
## `TorqueSpawner`
416

517
Maintainers:

batchspawner/batchspawner.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,8 @@ class SlurmSpawner(UserEnvMixin,BatchSpawnerRegexStates):
639639
def parse_job_id(self, output):
640640
# make sure jobid is really a number
641641
try:
642+
# use only last line to circumvent slurm bug
643+
output = output.splitlines()[-1]
642644
id = output.split(';')[0]
643645
int(id)
644646
except Exception as e:

0 commit comments

Comments
 (0)