Skip to content

Commit efb187a

Browse files
committed
Tests: set 'mock_port' and 'server' explicitely
- Modern traitlets doesn't set arbitrary keyword arguments, and these two attributes are not traitlets. Thus, set them explicitely after spawner creation. - This may fail (server) on the jupyterhub < 0.8 branch, but that is deprecated and I will likely remove it shortly.
1 parent 6534d5c commit efb187a

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

batchspawner/tests/test_spawners.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,20 @@ def new_spawner(db, spawner_class=BatchDummy, **kwargs):
6161
hub = Hub()
6262
user = User(user, {})
6363
server = Server()
64-
kwargs.setdefault('server', server)
64+
# Set it after constructions because it isn't a traitlet.
6565
kwargs.setdefault('hub', hub)
6666
kwargs.setdefault('user', user)
67-
kwargs.setdefault('mock_port', testport)
6867
kwargs.setdefault('poll_interval', 1)
6968
if version_info < (0,8):
70-
return spawner_class(db=db, **kwargs)
69+
spawner = spawner_class(db=db, **kwargs)
70+
spawner.mock_port = testport
7171
else:
7272
print("JupyterHub >=0.8 detected, using new spawner creation")
73-
return user._new_spawner('', spawner_class=spawner_class, **kwargs)
73+
# These are not traitlets so we have to set them here
74+
spawner = user._new_spawner('', spawner_class=spawner_class, **kwargs)
75+
spawner.server = server
76+
spawner.mock_port = testport
77+
return spawner
7478

7579
def test_stress_submit(db, io_loop):
7680
for i in range(200):

0 commit comments

Comments
 (0)