Skip to content

Commit f0b091f

Browse files
committed
Set port during tests
- #139 changes port handling, this makes tests pass. - Sets attribute mock_port, which gets used during the port polling phase.
1 parent 648cf4c commit f0b091f

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

batchspawner/batchspawner.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,10 @@ def start(self):
375375
self.ip = self.state_gethost()
376376
while self.port == 0:
377377
yield gen.sleep(self.startup_poll_interval)
378+
# Test framework: For testing, mock_port is set because we
379+
# don't actually run the single-user server yet.
380+
if hasattr(self, 'mock_port'):
381+
self.port = self.mock_port
378382

379383
if jupyterhub.version_info < (0,7):
380384
# store on user for pre-jupyterhub-0.7:

batchspawner/tests/test_spawners.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def new_spawner(db, spawner_class=BatchDummy, **kwargs):
6464
kwargs.setdefault('server', server)
6565
kwargs.setdefault('hub', hub)
6666
kwargs.setdefault('user', user)
67-
kwargs.setdefault('current_port', testport)
67+
kwargs.setdefault('mock_port', testport)
6868
kwargs.setdefault('INTERRUPT_TIMEOUT', 1)
6969
kwargs.setdefault('TERM_TIMEOUT', 1)
7070
kwargs.setdefault('KILL_TIMEOUT', 1)

0 commit comments

Comments
 (0)