Skip to content

Commit 1c48b96

Browse files
committed
Fix LocalRepo2dockerBuild to work with latest BuildExecutor
1 parent 79731ac commit 1c48b96

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

binderhub/build_local.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from threading import Thread
1212

1313
from tornado.log import app_log
14+
from traitlets import default
1415

1516
from .build import BuildExecutor, ProgressEvent
1617

@@ -111,6 +112,15 @@ class LocalRepo2dockerBuild(BuildExecutor):
111112
WARNING: This is still under development. Breaking changes may be made at any time.
112113
"""
113114

115+
@default("identifier")
116+
def _identifier_default(self):
117+
try:
118+
import repo2docker
119+
120+
return repo2docker.__version__
121+
except ImportError:
122+
return ""
123+
114124
def submit(self):
115125
"""
116126
Run a build to create the image for the repository.

testing/local-binder-local-hub/binderhub_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
c.BinderHub.builder_required = False
2525

2626
c.BinderHub.build_class = LocalRepo2dockerBuild
27-
c.BinderHub.push_secret = None
27+
c.BinderHub.push_secret = ""
2828
c.BinderHub.launch_quota_class = LaunchQuota
2929

3030
c.BinderHub.about_message = "This is a local dev deployment without Kubernetes"

0 commit comments

Comments
 (0)