Skip to content

Commit 1efa7b8

Browse files
committed
better comments
1 parent 33b6ae8 commit 1efa7b8

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

binderhub/repoproviders.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,10 @@ def get_resolved_ref(self):
227227
async def get_resolved_spec(self):
228228
if not hasattr(self, 'record_id'):
229229
self.record_id = await self.get_resolved_ref()
230-
# zenodo registers a DOI which represents all versions.
230+
# zenodo registers a DOI which represents all versions of a software package
231231
# and it always resolves to latest version
232-
# for that case, we have to replace it with record id
232+
# for that case, we have to replace the version number in DOIs with
233+
# the specific (resolved) version (record_id)
233234
resolved_spec = self.spec.split("zenodo")[0] + "zenodo." + self.record_id
234235
return resolved_spec
235236

@@ -275,7 +276,8 @@ async def get_resolved_spec(self):
275276
self.record_id = await self.get_resolved_ref()
276277

277278
# spec without version is accepted as version 1 - check get_resolved_ref method
278-
# so we first strip article id and version and add it again
279+
# for that case, we have to replace the version number in DOIs with
280+
# the specific (resolved) version (record_id)
279281
resolved_spec = self.spec.split("figshare")[0] + "figshare." + self.record_id
280282
return resolved_spec
281283

binderhub/tests/test_repoproviders.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ async def test_zenodo(spec, resolved_spec, resolved_ref, resolved_ref_url, build
7474
'9782777.v1',
7575
'https://doi.org/10.6084/m9.figshare.9782777.v1',
7676
'figshare-9782777.v1'],
77+
# spec without version is accepted as version 1 - check FigshareProvider.get_resolved_ref()
7778
['10.6084/m9.figshare.9782777',
7879
'10.6084/m9.figshare.9782777.v1',
7980
'9782777.v1',

0 commit comments

Comments
 (0)