Skip to content

Commit 232963c

Browse files
Use repo_providers to generate select box
1 parent 9273e5b commit 232963c

File tree

3 files changed

+25
-5
lines changed

3 files changed

+25
-5
lines changed

binderhub/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def get(self):
3535
google_analytics_code=self.settings['google_analytics_code'],
3636
google_analytics_domain=self.settings['google_analytics_domain'],
3737
extra_footer_scripts=self.settings['extra_footer_scripts'],
38-
repo_providers=SPEC_NAMES,
38+
repo_providers=self.settings['repo_providers'],
3939
)
4040

4141

binderhub/repoproviders.py

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,8 @@ class ZenodoProvider(RepoProvider):
212212
"""
213213
name = Unicode("Zenodo")
214214

215+
display_name = "Zenodo DOI"
216+
215217
labels = {
216218
"text": "Zenodo DOI (10.5281/zenodo.3242074)",
217219
"tag_text": "Git ref (branch, tag, or commit)",
@@ -256,6 +258,9 @@ class FigshareProvider(RepoProvider):
256258
Users must provide a spec consisting of the Figshare DOI.
257259
"""
258260
name = Unicode("Figshare")
261+
262+
display_name = "Figshare DOI"
263+
259264
url_regex = re.compile(r"(.*)/articles/([^/]+)/([^/]+)/(\d+)(/)?(\d+)?")
260265

261266
labels = {
@@ -306,6 +311,8 @@ def get_build_slug(self):
306311
class DataverseProvider(RepoProvider):
307312
name = Unicode("Dataverse")
308313

314+
display_name = "Dataverse DOI"
315+
309316
labels = {
310317
"text": "Dataverse DOI (10.7910/DVN/TJCLKP)",
311318
"tag_text": "Git ref (branch, tag, or commit)",
@@ -370,6 +377,9 @@ class HydroshareProvider(RepoProvider):
370377
Users must provide a spec consisting of the Hydroshare resource id.
371378
"""
372379
name = Unicode("Hydroshare")
380+
381+
display_name = "Hydroshare resource"
382+
373383
url_regex = re.compile(r".*([0-9a-f]{32}).*")
374384

375385
labels = {
@@ -442,6 +452,8 @@ class GitRepoProvider(RepoProvider):
442452

443453
name = Unicode("Git")
444454

455+
display_name = "Git repository"
456+
445457
labels = {
446458
"text": "Arbitrary git repository URL (http://git.example.com/repo)",
447459
"tag_text": "Git ref (branch, tag, or commit) SHA",
@@ -511,6 +523,8 @@ class GitLabRepoProvider(RepoProvider):
511523

512524
name = Unicode('GitLab')
513525

526+
display_name = "GitLab.com"
527+
514528
hostname = Unicode('gitlab.com', config=True,
515529
help="""The host of the GitLab instance
516530
@@ -568,6 +582,7 @@ def _default_git_credentials(self):
568582
}
569583

570584
def __init__(self, *args, **kwargs):
585+
print("GITLAB contructor")
571586
super().__init__(*args, **kwargs)
572587
self.quoted_namespace, unresolved_ref = self.spec.split('/', 1)
573588
self.namespace = urllib.parse.unquote(self.quoted_namespace)
@@ -626,6 +641,8 @@ class GitHubRepoProvider(RepoProvider):
626641
"""Repo provider for the GitHub service"""
627642
name = Unicode('GitHub')
628643

644+
display_name = 'GitHub'
645+
629646
# shared cache for resolved refs
630647
cache = Cache(1024)
631648

@@ -872,8 +889,11 @@ class GistRepoProvider(GitHubRepoProvider):
872889
If master or no ref is specified the latest revision will be used.
873890
"""
874891

875-
name = Unicode('Gist')
876-
hostname = Unicode('gist.github.com')
892+
name = Unicode("Gist")
893+
894+
display_name = "Gist"
895+
896+
hostname = Unicode("gist.github.com")
877897

878898
allow_secret_gist = Bool(
879899
default_value=False,

binderhub/templates/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ <h4 id="form-header" class='row'>Build and launch a repository</h4>
5252
<span class="caret"></span>
5353
</button>
5454
<ul class="dropdown-menu" id="provider_prefix_sel">
55-
{% for provider_prefix, provider_name in repo_providers.items() %}
56-
<li class="dropdown-item" value={{provider_prefix}}><a href="#">{{provider_name}}</a></li>
55+
{% for provider_prefix, provider in repo_providers.items() %}
56+
<li class="dropdown-item" value={{provider_prefix}}><a href="#">{{provider.display_name}}</a></li>
5757
{% endfor %}
5858
</ul>
5959
</div>

0 commit comments

Comments
 (0)