Skip to content

Commit 25c0bb0

Browse files
committed
ci: bugfix binderhub image not updating on change
Chartpress 1.0.0 contained a regression, and our publishing pipeline was using chartpress 1.0.0 instead of 0.7.0, so it was affected. This made the image version used by binderhub since chartpress 1.0.0 was released in 21 Nov 2020 be the same version as the image-cleaner image. The only PR that was influenced by this mishap was a PR merged ~2 hours. With this commit, it should not happen again.
1 parent d5ecd3d commit 25c0bb0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
run: |
4141
. ./ci/common
4242
setup_helm v3.4.1
43-
pip install --no-cache-dir chartpress
43+
pip install --no-cache-dir chartpress==1.0.*
4444
4545
- name: Setup push rights to jupyterhub/helm-chart
4646
# This was setup by...

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
beautifulsoup4
2-
chartpress==0.7.*
2+
chartpress==1.0.*
33
click
44
codecov
55
html5lib

0 commit comments

Comments
 (0)