refactor: use dedicated name for Docker and Podman socket

This will make things clearer when deployed.

Author: sgaist

helm-chart/binderhub/files/binderhub_config.py

@@ -50,8 +50,8 @@ def get_value(key, default=None):
 if imageBuilderType in ["dind", "pink"]:
     hostSocketDir = get_value(f"{imageBuilderType}.hostSocketDir")
     if hostSocketDir:
-        c.BinderHub.build_docker_host = f"unix://{hostSocketDir}/docker.sock"
-
+        socketname = "docker" if imageBuilderType == "dind" else "podman"
+        c.BinderHub.build_docker_host = f"unix://{hostSocketDir}/{socketname}.sock"
 
 if c.BinderHub.auth_enabled:
     hub_url = urlparse(c.BinderHub.hub_url)

helm-chart/binderhub/templates/container-builder/daemonset.yaml

@@ -72,7 +72,7 @@ spec:
             - system
             - service
             - --time=0
-            - unix://{{ $builder.hostSocketDir }}/docker.sock
+            - unix://{{ $builder.hostSocketDir }}/podman.sock
           securityContext:
             privileged: true
             runAsUser: 0

helm-chart/binderhub/templates/image-cleaner.yaml

@@ -93,7 +93,7 @@ spec:
           type: DirectoryOrCreate
       - name: socket-pink
         hostPath:
-          path: {{ .Values.pink.hostSocketDir }}/docker.sock
+          path: {{ .Values.pink.hostSocketDir }}/podman.sock
           type: Socket
       {{- end }}